Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAVC Remand: Litigation Support Form (Back End) #15281

Closed
3 tasks
hschallhorn opened this issue Sep 21, 2020 · 1 comment · Fixed by #15372 or #15351
Closed
3 tasks

CAVC Remand: Litigation Support Form (Back End) #15281

hschallhorn opened this issue Sep 21, 2020 · 1 comment · Fixed by #15372 or #15351
Assignees
@lomky
Labels
Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: New Development New feature development User: Litigation Support
Milestone
PI5-S4: The Emanc...

Comments

@hschallhorn
Copy link
Contributor

Description

This ticket is to create the model to store information submitted on the front end cavc remand form in #14795

Acceptance criteria

  • Model created
  • Controller to create instance of the model
  • All fields on the form are required in the controller/model

Background/context/resources

Technical notes
@hschallhorn
Copy link
Contributor Author

what is this chart?

1 | 
2 | 
3 | ||||||||||
5 | ||
8 |

"Steak and potatoes" rails code, nothing out there engineering wise, set set of fields to store. Could be a 5 as it is the first cavc ticket. Testing for both model and controller could move this into a 5 as well.

@araposo-tistatech araposo-tistatech mentioned this issue Sep 21, 2020
Closed
@araposo-tistatech araposo-tistatech added this to the PI5-S4: XXX Sprint milestone Sep 21, 2020
@hschallhorn hschallhorn self-assigned this Sep 23, 2020
@hschallhorn hschallhorn mentioned this issue Sep 28, 2020
Closed
26 tasks
@hschallhorn hschallhorn removed their assignment Sep 28, 2020
@lomky lomky self-assigned this Sep 28, 2020
This was referenced Sep 30, 2020
Merged
Merged
@lomky lomky linked a pull request Oct 2, 2020 that will close this issue
CAVC Remand model & Controller #15351
Merged
16 tasks
va-bot pushed a commit that referenced this issue Oct 2, 2020
@lomky
CAVC Remand model & Controller (#15351)
d466620 
Completes #15281

### Description
Add the new model & Controller
 
### Acceptance Criteria
- [x] Model for cavc remand created
- [x] Controller for cavc remand created
- [ ] Validations
     - [ ] All fields required except as otherwise excepted below
     - [ ] Mandate Subtype (required for Mandate, not required for Straight Reversal nor Death Dismissal)
     - [x] Mandate date and Judgement date (required for jmr/jmpr, not required for mdr)
     - [ ] Decision issue ids (all must match if this is a jmr)

### Testing Plan
 1. Tests, reviewed for coverage, pass
 2. Maybe instantiate one in console? not sure what else to do here

### Code Documentation Updates
- [ ] Add or update code comments at the top of the class, module, and/or component.

### Database Changes
*Only for Schema Changes*

* [x] Timestamps (created_at, updated_at) for new tables
* [x] Column comments updated
* [x] Have your migration classes inherit from `Caseflow::Migration`, especially when adding indexes (use `add_safe_index`)
* [x] Verify that `migrate:rollback` works as desired ([`change` supported functions](https://edgeguides.rubyonrails.org/active_record_migrations.html#using-the-change-method))
* [x] Query profiling performed (eyeball Rails log, check bullet and fasterer output)
* [x] Appropriate indexes added (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
* [x] DB schema docs updated with `make docs` (after running `make migrate`)
* [x] #appeals-schema notified with summary and link to this PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
Feature: generic-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: New Development New feature development User: Litigation Support
Projects
None yet
Milestone
PI5-S4: The Emancipation Proclamation...
3 participants
@lomky @hschallhorn @araposo-tistatech