Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark Cases as OT | Success Banner Remains Persistent #14667

Closed
2 tasks
araposo-tistatech opened this issue Jul 9, 2020 · 2 comments · Fixed by #14702
Closed
2 tasks

Mark Cases as OT | Success Banner Remains Persistent #14667

araposo-tistatech opened this issue Jul 9, 2020 · 2 comments · Fixed by #14702
Assignees
@lomky
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: Bug
Milestone
PI4-S6: Sea of Tr...

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented Jul 9, 2020 •
edited by hschallhorn
Loading

Description

When a VLJ successfully marks a case as OT the success banner remains persistent even after clicking out of the case details and going to the VLJs Your Cases page.

It also displays in the modal if the mark cases as OT link is clicked again.

Screenshot for reference:
Success Banner

Success Banner in Modal

Acceptance criteria

  • The success banner does not remain after clicking out of the case details page
  • The success banner does not remain after clicking the Mark Case as OT link again.

Background/context/resources

Occurred during dogfooding Issues #11 & #13 in document
@araposo-tistatech araposo-tistatech added Product: caseflow-queue Type: Bug Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Jul 9, 2020
@ajspotts
Copy link
Contributor

ajspotts commented Jul 9, 2020

what is this chart?

1 | ||
2 | ||||||||
3 | ||
5 | 
8 |

See resetErrorState or resetAlerts.

Why 1?

  • Clear problem we've solved similar of before

Why 2?

  • State management is tricksy :myprecious:

Why 3?

  • Ensure we aren't clearing success banners that should persist

@hschallhorn hschallhorn mentioned this issue Jul 13, 2020
Closed
@lomky lomky self-assigned this Jul 14, 2020
@lomky lomky mentioned this issue Jul 15, 2020
Merged
10 tasks
@lomky
Copy link
Contributor

lomky commented Jul 16, 2020

SCREEN BEFORE AFTER
Overtime Modal OT modal - before OT modal
Queue case list - before case list
Place On Hold Modal on hold modal - before on hold modal

va-bot pushed a commit that referenced this issue Jul 16, 2020
@lomky
Properly clear overtime success message (#14702)
12ac8da 
Resolves #14667 

### Description
Properly clears the Success message so it doesn't appear on the next modal (un/mark OT, place on hold) or back on the Queue

### Acceptance Criteria
- [ ]  The success banner does not remain after clicking out of the case details page
- [ ] The success banner does not remain after clicking the Mark Case as OT link again.
- [ ] [BONUS] The success banner does not remain after selecting "Place task on hold"

### Testing Plan
1. Sign in as a Judge (abshire works) and load your queue - click into a legacy case
1. Mark the case as overtime
   - [ ] Banner appears
1. Open the modal to Unmark case as overtime
   - [ ] Confirm banner does _not_ move to the modal
1. Confirm removal over overtime
   - [ ] Banner appears
1. Click Queue at the top of the page to load your queue
   - [ ] Banner does not reappear on `/queue`
1. Click into an AMA case
1. Mark the case as overtime
   - [ ] Banner appears
1. Select the dropdown action `Put Task On Hold`
   - [ ] Confirm banner does _not_ move to the modal

### User Facing Changes
 - [x] Screenshots of UI changes added to PR & Original Issue

SCREEN | BEFORE|AFTER
---|---|---
Overtime Modal | ![OT modal - before](https://user-images.githubusercontent.com/6129479/87686785-ed421c80-c752-11ea-9ca0-d4350ca68c11.gif) | ![OT modal](https://user-images.githubusercontent.com/6129479/87686790-eddab300-c752-11ea-82ef-43a4ef548b7e.gif)
Queue | ![case list - before](https://user-images.githubusercontent.com/6129479/87686805-f4692a80-c752-11ea-9b09-c6f1e83b57f2.gif) | ![case list](https://user-images.githubusercontent.com/6129479/87686809-f59a5780-c752-11ea-85fa-31e98cb6f3a8.gif)
Place On Hold Modal | ![on hold modal - before](https://user-images.githubusercontent.com/6129479/87686835-fd59fc00-c752-11ea-9963-fc0c79874c99.gif) | ![on hold modal](https://user-images.githubusercontent.com/6129479/87686836-fdf29280-c752-11ea-9875-2084f4151835.gif)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: Bug
Projects
None yet
Milestone
PI4-S6: Sea of Tranquility Sprint
Development

Successfully merging a pull request may close this issue.

Properly clear overtime success message department-of-veterans-affairs/caseflow
4 participants
@lomky @ajspotts @hschallhorn @araposo-tistatech