Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Caseflow user status management allow search by name #14089

Closed
1 task done
araposo-tistatech opened this issue Apr 24, 2020 · 6 comments · Fixed by #14231
Closed
1 task done

Caseflow user status management allow search by name #14089

araposo-tistatech opened this issue Apr 24, 2020 · 6 comments · Fixed by #14231
Assignees
@lomky
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue release-notes This ticket should get release notes generated on merge Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature
Milestone
PI4-S1: David Hun...

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented Apr 24, 2020 •
edited by lomky
Loading

User or job story

User story: As an admin, I need the ability to search for a user on the user status management page by their name as well as the CSS ID, so that I can locate and deactivate a user quickly.

Acceptance criteria

  • users with access to the user status management page have the ability to search for a user by name and CSS ID

Background/context

Often times the admin does not know the users CSS ID nor have access to it after the user they are attempting to deactivate has left the Board.

Technical notes

As the user list is extensive it may take some time for the search to populate with names. Would searching with a minimum of 4 or 5 letters help speed up populating the list?

Other notes

Resources/other links
@araposo-tistatech araposo-tistatech added Type: Enhancement Enhancement to an existing feature Product: caseflow-queue Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Apr 24, 2020
@pkarman
Copy link
Contributor

pkarman commented Apr 24, 2020

Tech note: UserFinder should match on name, so if (a) that class is being used and (b) it is not finding by name, we might have a bug.

https://github.com/department-of-veterans-affairs/caseflow/blob/master/app/services/user_finder.rb#L50

@ajspotts
Copy link
Contributor

what is this chart?

1 | |||||
2 | |||||||
3 | 
5 | 
8 |

Why 1?

  • We already have a dropdown that does this. Should be able to hotswap the two components 🤞

Why 2?

  • Hot swap my not be that straightforward
  • Add tests

@araposo-tistatech araposo-tistatech added this to the PI4-S1: XXX Sprint milestone May 4, 2020
@yoomlam yoomlam mentioned this issue May 4, 2020
Closed
@lomky lomky self-assigned this May 5, 2020
This was referenced May 8, 2020
Merged
Closed
@lomky lomky added the release-notes This ticket should get release notes generated on merge label May 12, 2020
@lomky
Copy link
Contributor

lomky commented May 12, 2020

@araposo-tistatech this is set to merge and should go out today or tomorrow. There is a slight user-facing change in appearance and behavior, though only for System Admin users. Probably worth a release note!

@araposo-tistatech
Copy link
Author

@lomky is there anyway to re-record the gifs you have in the PR without the URL bar included? I would like to add them to the post and would have created some myself, but looks like this change is not in demo yet.

va-bot pushed a commit that referenced this issue May 12, 2020
@lomky
User Management Page - User Search Improvement (#14231)
6acd55f 
Resolves #14089 

### Description
Updates our User Management page to search based on user name or css id, dynamically.

### Acceptance Criteria
- [ ] Code compiles correctly
- [ ] Users with access to the user status management page have the ability to search for a user by name and CSS ID

### Testing Plan
1. Go to [`test/users`](http://localhost:3000/test/users) and sign in as the `SystemAdmin` user
1. Navigate to [User Management](http://localhost:3000/user_management)
 - [ ] Search for "`Jolly`" to confirm CSS search
 - [ ] Search for "`Wilson`" to confirm Name search
 - [ ] Search for "`Intake`" to confirm you can get a mix of CSS ID & Name based results
 - [ ] Confirm marking the user inactive still functions.
 - [ ] Confirm marking the user active still functions.

### User Facing Changes
 BEFORE|AFTER
 ---|---
![image](https://user-images.githubusercontent.com/6129479/81444075-8b5aaa80-9144-11ea-8a44-f3214331cfe9.png) | ![image](https://user-images.githubusercontent.com/6129479/81443992-649c7400-9144-11ea-9a2f-a3c99c81302a.png)
![image](https://user-images.githubusercontent.com/6129479/81444103-96add600-9144-11ea-83d5-94826d4fc927.png) | ![image](https://user-images.githubusercontent.com/6129479/81444033-77af4400-9144-11ea-80d3-b5942d621514.png)
![user_page_before](https://user-images.githubusercontent.com/6129479/81443678-daeca680-9143-11ea-8de0-9df6cf94304e.gif) | ![user_page_after](https://user-images.githubusercontent.com/6129479/81443685-dcb66a00-9143-11ea-82a4-f85d1e9aff2d.gif)
@lomky
Copy link
Contributor

lomky commented May 12, 2020

@araposo-tistatech if you redeploy our echo demo it will have it now that it merged! We're past the deploy for today so this won't release until tomorrow.

@lomky
Copy link
Contributor

lomky commented May 12, 2020

Nevermind I found a quick way to crop it!

Before After
ezgif com-crop ezgif com-crop(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue release-notes This ticket should get release notes generated on merge Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature
Projects
None yet
Milestone
PI4-S1: David Hunter Sprint
Development

Successfully merging a pull request may close this issue.

User Management Page - User Search Improvement department-of-veterans-affairs/caseflow
4 participants
@pkarman @lomky @ajspotts @araposo-tistatech