Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BVA Dispatch: Add Validation to Special Issues #14018

Closed
4 tasks done
araposo-tistatech opened this issue Apr 16, 2020 · 1 comment · Fixed by #14047
Closed
4 tasks done

BVA Dispatch: Add Validation to Special Issues #14018

araposo-tistatech opened this issue Apr 16, 2020 · 1 comment · Fixed by #14047
Assignees
@hschallhorn
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-dispatch Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature
Milestone
PI3-S7: Library o...

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented Apr 16, 2020 •
edited by hschallhorn
Loading

User or job story

Job story: When a BVA Dispatch team member clicks continue on the special issues page, and a special issue is not chosen or the "No Special Issues" checkbox is not selected, they need to see an error message noting a selection needs to be made on the page.

Acceptance criteria

  • add error if no issue is selected "Choose at least one. If no special issues apply to this case, please confirm by selecting “No special issues” (Legacy Only)
  • Please put this work behind the feature toggle: :special_issues_revamp
  • This feature should be accessible to the following user groups: BVA Dispatch
  • Include screenshot(s) in the Github issue if there are front-end changes

Release notes

New special issues were added to the special issues page in Dispatch during the checkout process. Along with the new issues a "No Special Issues" option was added as selection is required on this page.

Designs

Background/context

We are adding a "no special issues" option on the special issues page so validation will need to occur on the page to ensure a selection is being made.

Technical notes

Other notes

Resources/other links

Ref: #13735 for validation completed in Queue.
@araposo-tistatech araposo-tistatech added Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-dispatch Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature labels Apr 16, 2020
@yoomlam
Copy link
Contributor

yoomlam commented Apr 16, 2020

what is this chart?

1 | |||||
2 | |||||||
3 | 
5 | 
8 |

Use same wording as during Judge/Atty checkout.

Why 1?

  • Validation already exists elsewhere, can replicate

Why 2?

  • Dispatch is laid out differently than Queue, so maybe some ramp up

@hschallhorn hschallhorn mentioned this issue Apr 20, 2020
Closed
@hschallhorn hschallhorn self-assigned this Apr 20, 2020
@hschallhorn hschallhorn mentioned this issue Apr 20, 2020
Merged
1 task
va-bot pushed a commit that referenced this issue Apr 21, 2020
@hschallhorn
Validate special issues dispatch page (#14047)
83cdb76 
Resolves #14018

### Description
Adds validation to the special issues page for dispatching legacy appeals

### Acceptance Criteria
- [ ] Code compiles correctly

### Testing Plan
#### FeatureToggle On
1. Feature toggle!
```ruby
> FeatureToggle.enable!(:special_issues_revamp)
```
2. Log in as BVAGWHITE
3. Go to `/dispatch` and hit `Establish New Claim`
4. Hit "Route Claim" while no special issues are selected
5. Confirm error
6. Select a special issue and hit "Route Claim"
7. confirm success!

### User Facing Changes
![Screen Shot 2020-04-20 at 5 10 34 PM](https://user-images.githubusercontent.com/45575454/79889333-de560300-83cb-11ea-96df-c1bba7edb26f.png)
@lomky lomky mentioned this issue Jul 8, 2020
Closed
1 task
@araposo-tistatech araposo-tistatech mentioned this issue Jul 16, 2020
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hschallhorn hschallhorn

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-dispatch Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature
Projects
None yet
Milestone
PI3-S7: Library of Congress (Innovati...
Development

Successfully merging a pull request may close this issue.

Validate special issues dispatch page department-of-veterans-affairs/caseflow
3 participants
@hschallhorn @yoomlam @araposo-tistatech