Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intake | VBA COVID-19 Update | Allow timeliness exemptions for legacy issue opt-ins #13817

Closed
7 tasks
leikkisa opened this issue Mar 28, 2020 · 3 comments
Closed
7 tasks

Comments

@leikkisa
Copy link
Contributor

leikkisa commented Mar 28, 2020

User or job story

User story: As a VBA user (claims assistant, VSR), I need timeliness exemptions to also apply to legacy issue opt-ins.

Acceptance criteria

  • Please put this work behind the feature toggle: [covid_timeliness_exemption]
  • The following changes only apply to higher level reviews and supplemental claims
  • The list of matchable legacy issues shown on the decision review does not check SOC eligibility, it only checks the NOD date eligibility
  • For Higher Level Reviews - If either the request issue or the connected legacy issue is untimely, show the untimely issue modal (see tech notes Set up master as protected branch #1).
  • For Supplemental Claims - If the connected legacy issue is untimely, show the untimely issue modal (see tech notes add dsva as admin #2)
  • Update the modal copy to reflect whether the request issue and/or the legacy issue are ineligible
  • Update styling on Untimely modal to increase space between the copy and the radio button to ~25px (see Rutvi's comment below)

Out of scope

  • Updating the actual rules for legacy issue timeliness on the backend
  • Updating the ineligibility message on the front-end

Copy

Current copy

The issue requested isn't usually eligible because its decision date is older than what is allowed.

New copy

If the request issue is untimely:
Please note: The issue requested isn't usually eligible because its decision date is older than what is allowed.
(same as current copy but with "Please Note" added)

If only the legacy issue is ineligible:
Please Note: The legacy issue isn't eligible for SOC/SSOC opt-in unless an exemption has been requested for reasons related to COVID-19.

If both are ineligible:
Please note: The issue isn't usually eligible because its decision date is older than what is allowed, and the legacy issue issue isn't eligible for SOC/SSOC opt-in unless an exemption has been requested for reasons related to COVID-19.

Current design with original copy

Screen Shot 2020-04-01 at 11.29.20 AM.png

Release notes

Timeliness exemptions will also apply to legacy issue opt-ins for Higher Level Reviews and Supplemental Claims.

Technical notes

  1. Currently the untimely issue modal isn't concerned about legacy issue data, so you will need to add code to be able to access a legacy issue's eligibility status before the user submits adding the issue. The specific ineligibility reason we're looking for is: legacy_appeal_not_eligible. Currently, eligibility is checked on the front end in the AddedIssue component in getEligibility, which shows on the edit screen after a user has submitted their issue.

  2. Currently, the untimely issue modal does not appear in supplemental claims at all

@leikkisa leikkisa added the Epic label Apr 1, 2020
@leikkisa leikkisa changed the title Intake | Allow timeliness exemptions for legacy issue opt-ins Intake | COVID-19 Update | Allow timeliness exemptions for legacy issue opt-ins Apr 1, 2020
@leikkisa leikkisa removed the Epic label Apr 1, 2020
@leikkisa
Copy link
Contributor Author

leikkisa commented Apr 1, 2020

@rutvigupta-design Do you have any suggestions or feedback for the copy on this modal? I wonder if we shouldn't show the text about legacy issue eligibility unless they check "Yes", so that it's clear that it's related to the checkbox.

@rutvigupta-design
Copy link

@leikkisa is there a reason for saying "isn't usually eligible"? Usually to me is a little confusing because it makes it seem like there are other use cases but there is no further information about them. Would it be inaccurate to simply say "The issue requested isn't eligible because its decision date is older than what is allowed."

I think showing the legacy text up front is okay! It's better for users to see all the information up front in one place, and they may not notice text that is added above after they select the checkbox.

Two recommendations:

  1. Adding a "Please note:" before the instruction text. I think visually, it helps give the user context and separates that text from the issue above it.
  2. Increasing the space between the instructions and the "Did the applicant request an extension" question by 25px - I think overall, this is minor but can help the modal feel a bit more open. Please see an attached design for what this can look like.
    Untimely Issue Modal

@leikkisa
Copy link
Contributor Author

leikkisa commented Apr 6, 2020

@rutvigupta-design I added a couple of AC to add the "Please note:" and increase the spacing.

@leikkisa leikkisa added this to the PI3-S6: Civil Rights Sprint milestone Apr 7, 2020
@Sjones352 Sjones352 self-assigned this Apr 8, 2020
@msj0nes msj0nes changed the title Intake | COVID-19 Update | Allow timeliness exemptions for legacy issue opt-ins Intake | VBA COVID-19 Update | Allow timeliness exemptions for legacy issue opt-ins Apr 10, 2020
va-bot pushed a commit that referenced this issue Apr 20, 2020
Connects #13817
**If the request issue is untimely** 
<img width="1113" alt="Screen Shot 2020-04-09 at 8 39 31 PM" src="https://user-images.githubusercontent.com/23080951/78953260-450f1e80-7aa6-11ea-9258-6902b6a13555.png">

**If only the legacy issue is ineligible**
<img width="1065" alt="Screen Shot 2020-04-15 at 1 32 06 AM" src="https://user-images.githubusercontent.com/23080951/79376399-1e2e6d80-7f28-11ea-829f-5315cdb32e8a.png">

**If both are ineligible**
<img width="1183" alt="Screen Shot 2020-04-16 at 1 13 45 PM" src="https://user-images.githubusercontent.com/23080951/79486076-2ba92d80-7fe4-11ea-8053-d4df36931f9a.png">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants