Make cancelled appeals more obvious in appeal search

[yoomlam]

Description

UI problem

At the Board's request, two appeals were modified so that the users will not be able to see or search for them based on the docket number.
(The original request from Martina was to delete them so that users are not confused about cancelled appeals and their assignment to users -- screenshots in slack)

• Martina: "This makes it appear its still active and assigned to a user to work"

Cancelled appeals should be made more obvious in the UI.

Needs Product, Designer, and end-user input.

Per end-user: Show the appeal in search, but show the status as "Cancelled"

Acceptance criteria

• Distinguish cancelled appeals in the Case Search Results page
  • Do not display “assigned to” and indicate that appeal is cancelled/remove/what have you
  • Display appeals with no issues associated as "cancelled" in the status column of the search page
• Appeal is still clickable to be able to view the Case Details page

Background/context/resources

• https://dsva.slack.com/archives/CJL810329/p1583769022223100
• https://dsva.slack.com/archives/CHX8FMP28/p1583764614216100

Technical notes

Design

[lomky]

what is this chart?

1 | 
2 | |||
3 | ||||||||||
5 | 
8 | 

This is specifically about how appeals appear in the search results page. Later we may want to add something to the Case Details page. Backend change to provide the info that the appeal is changed, but this is mostly front end work

Estimated at a 3.

Backend and frontend changes, with a mild amount of unknown in the AC waiting for final design.

[yoomlam]

Ultimately deleted the two appeals due to reporting errors.

[pkarman]

I highly recommend leveraging the appeal.status method to determine the business logic for this, as it is aligned with what BVA users will expect in their reporting.

[hschallhorn]

Yep, looks like we just don't serialize ama appeals' status, so that value doesn't exist on the front end. That may be the only change we need to add for the status portion of this.

[geronimoramos]

Making the Canceled status in red #e31c3d makes a lot of sense to make it obvious for the user.

And just a thought, do we want it to be more obvious as well to the user from the Case Details page? Not sure if it's a problem, but an idea would be using a Warning Status alert component at the top.

[pkarman]

On case details it seemed important to BVA folks to "unassign" the case if it is cancelled, so whatever logic is setting the "assigned to" value should take the status into account.