Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show Overtime Cases #13417

Closed
14 tasks
araposo-tistatech opened this issue Feb 14, 2020 · 4 comments · Fixed by #13984
Closed
14 tasks

Show Overtime Cases #13417

araposo-tistatech opened this issue Feb 14, 2020 · 4 comments · Fixed by #13984
Assignees
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented Feb 14, 2020

User or job story

Job story: When a VLJ or SSC assigns a case to their attorney, they need to see if cases currently part of their attorney's caseload are overtime, so they know they can continue to assign more cases to them.

Acceptance criteria

  • Please put this work behind the feature toggle: :overtime_revamp
  • This feature should be accessible to the following user groups: VLJs, SSCs, & Attorneys
  • Include screenshot(s) in the Github issue if there are front-end changes
  • Update documentation: notify training for training documentation updates
  • If the case has been designated as OT in Caseflow by attorney or Mark Cases as OT #13415 show the OT badge on the
    • Judge & SSC "Assign" page
    • Judge & SSC & the individual attorney "Your Cases" queues
    • In the case details view of the case for only attorneys and judges
    • In search results for only attorneys and judges
  • If the work product field in VACOLS is either - OT DEC, OT VHA, OT IME - show the OT badge on the
    • Judge & SSC "Assign" page
    • Judge & SSC & the individual attorney "Your Cases" queues
    • In the case details view of the case for only attorneys and judges
    • In search results for only attorneys and judges

Release notes

Designs

image

Technical notes

We are currently only tracking when a case was marked as being worked on OT at the time of the attorney. Any changes to OT-related data will need to be captured.

Overtime data is sent to the following Tableau reporting:
The Attorney production and DAS ratings and comments workbooks

Engineering should inquire with the team that will actually do the work to update Tableau reports what format the OT data should be formatted in.

Resources/other links
Product Brief: https://docs.google.com/document/d/1OayEvH7KAAojD9XVHkfUHyLdyECC-PkeIsrEx9krqDA/edit#

@araposo-tistatech araposo-tistatech added Product: caseflow-queue Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Feb 14, 2020
@araposo-tistatech araposo-tistatech changed the title Show Overtime Cases on Attorney Caseload Show Overtime Cases Mar 2, 2020
@araposo-tistatech araposo-tistatech added the Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests label Mar 5, 2020
@hschallhorn
Copy link
Contributor

Estimating at a 3!

Release notes! Ensure users know only legacy cases will have the overtime badge until followup work is done on marking ama cases as overtime. Do we want to put this behind a feature flag until that's done?
What is this graph?

1 | 
2 | |
3 | |||||||
5 | |||||
8 | |

Can add a field to the serializer for legacy appeals. Can also replicate design for hearing badge. Hearing badge column may not be generic enough to accept other badges. Could be a 5 because of translating backend information to the front end and further discrepancies between legacy and ama appeals.

@hschallhorn
Copy link
Contributor

Check out this link for where we can see if an ama case case been marked overtime by an atty.

@hschallhorn
Copy link
Contributor

hschallhorn commented Apr 2, 2020

  • In the case details view of the case for only attorneys and judges
  • In search results for only attorneys and judges

@araposo-tistatech Can we get clarity on if this is correct, especially given the attorney union discussed today. Do we want to limit this to the assigner, all SSCs, the assigned attorney, etc?

EDIT: Confirmed correct!

@geronimoramos
Copy link

OT badge color specs:
/* Gray-dark */

background: #323A45;
border-radius: 4px;

@hschallhorn hschallhorn self-assigned this Apr 13, 2020
va-bot pushed a commit that referenced this issue Apr 16, 2020
Resolves #13417

### Description
Displays a badge for any legacy appeal with an overtime work product or ama appeal with an attorney case review marked as overtime

### Acceptance Criteria
- [ ] All work is behind `:overtime_revamp` feature flag
- [ ] Only VLJs, SSCs, & Attorneys are the only users that can view the badge
- [ ] If the case has been designated as OT in Caseflow by attorney or #13415 show the OT badge on the 
   - [ ] ~~Judge & SSC "Assign" page~~ (Cannot replicate in dev testing as there will be no AttorneyCaseReview at this stage)
   - [ ] Judge & SSC & the individual attorney"Your Cases"  queues
   - [ ] In the case details view of the case
   - [ ] In search results
- [ ] If the work product field in VACOLS is either - OT DEC, OT VHA, OT IME - show the OT badge on the
   - [ ] ~~Judge & SSC "Assign" page~~ (Cannot replicate in dev testing as there will be no Decass record at this stage)
   - [ ] Judge & SSC & the individual attorney "Your Cases"  queues
   - [ ] In the case details view of the case for only attorneys and judges
   - [ ] In search results for only attorneys and judges

### Testing Plan
#### AMA
1. Log in as BVAAABSHIRE and navigate to their queue
2. Pick a random ama case
3. Pretend the attorney marked this case as overtime
```ruby
FeatureToggle.enable!(:overtime_revamp)
uuid = "29fab5a2-b90a-4667-afae-5777af70e532"
appeal = Appeal.find_by(uuid: uuid)
appeal.latest_attorney_case_review.update!(overtime: true)
```
4. Refresh the page and ensure the overtime badge is shown in the user's queue
5. Go to the case details page of the case and ensure the badge is shown
6. Search for the case by copying the veteran id from the case details page and ensure the badge is shown
7. Log in as a non judge and non attorney user (BVALSPORER)
8. Search for the case by copying the veteran id from the case details page and ensure the badge is NOT shown
9. Click into the case details and ensure the badge is NOT shown

#### Legacy
1. Log in as BVAAABSHIRE and navigate to their queue
2. Pick a legacy appeal with a hearing
3. Pretend ththis case was marked as overtime in vacols
```ruby
FeatureToggle.enable!(:overtime_revamp)
vacols_id = 2226048
VACOLS::Decass.where(defolder: vacols_id).update_all(deprod: QueueMapper::OVERTIME_WORK_PRODUCTS.keys.first)
```
4. Refresh the page and ensure the overtime badge is shown in the user's queue
5. Go to the case details page of the case and ensure the badge is shown
6. Search for the case by copying the veteran id from the case details page and ensure the badge is shown
7. Log in as a non judge and non attorney user (BVALSPORER)
8. Search for the case by copying the veteran id from the case details page and ensure the overtime badge is NOT shown, but the hearing badge still is
9. Click into the case details and ensure the overtime badge is NOT shown, but the hearing badge still is

### User Facing Changes
#### Queue (No hearing)
![Screen Shot 2020-04-13 at 4 52 06 PM](https://user-images.githubusercontent.com/45575454/79160037-214e2000-7da7-11ea-93dc-d4cf5a0aa7ce.png)
#### Case details (No hearing)
![Screen Shot 2020-04-13 at 4 49 50 PM](https://user-images.githubusercontent.com/45575454/79159875-e1873880-7da6-11ea-9ea7-d8876198e39f.png)
#### Case search (No hearing)
![Screen Shot 2020-04-13 at 4 52 29 PM](https://user-images.githubusercontent.com/45575454/79160066-2f03a580-7da7-11ea-9e14-ac829cefb375.png)

#### Queue (With hearing)
![Screen Shot 2020-04-15 at 6 01 39 PM](https://user-images.githubusercontent.com/45575454/79393419-4a0b1c80-7f43-11ea-82d6-c4adcd0a7da4.png)
#### Case details (With hearing)
![Screen Shot 2020-04-13 at 4 52 58 PM](https://user-images.githubusercontent.com/45575454/79160144-50649180-7da7-11ea-962f-ab85cc9e9742.png)
#### Case search (With hearing)
![Screen Shot 2020-04-15 at 6 02 05 PM](https://user-images.githubusercontent.com/45575454/79393413-45deff00-7f43-11ea-83fd-7ccaca10d24f.png)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬 Type: Enhancement Enhancement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants