Move completed AttorneyTasks to new JudgeDecisionReviewTask on reassign

[hschallhorn]

Tableau reporting and some places in our code assumes and active or completed JudgeDecisionReviewTask will have a child AttorneyTask. In many cases this is not true.

jdr_tasks = JudgeDecisionReviewTask.not_cancelled
jdr_tasks.count
=> 6478
atty_tasks = AttorneyTask.not_cancelled

jdr_tasks_without_atty_tasks = jdr_tasks.where.not(id: atty_tasks.pluck(:parent_id))
jdr_tasks_without_atty_tasks.count
=> 382

# Let's look at the task trees for these to see what happened
puts jdr_tasks_without_atty_tasks.take(5).map { |task| task.appeal.structure_render(:status) }
Appeal 9285 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask completed
    └── BvaDispatchTask on_hold
        └── BvaDispatchTask assigned
Appeal 8479 [status]
└── RootTask completed
    ├── TrackVeteranTask completed
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    │       └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask cancelled
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask cancelled
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask cancelled
    ├── JudgeDecisionReviewTask completed
    └── BvaDispatchTask completed
        └── BvaDispatchTask completed
Appeal 10128 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask completed
    └── BvaDispatchTask on_hold
        └── BvaDispatchTask assigned
Appeal 10742 [status]
└── RootTask on_hold
    ├── DistributionTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    ├── JudgeDecisionReviewTask completed
    └── BvaDispatchTask on_hold
        └── BvaDispatchTask assigned
Appeal 46151 [status]
└── RootTask on_hold
    ├── TrackVeteranTask in_progress
    ├── DistributionTask completed
    │   └── InformalHearingPresentationTask completed
    │       └── InformalHearingPresentationTask completed
    ├── JudgeAssignTask completed
    ├── JudgeDecisionReviewTask cancelled
    │   └── AttorneyTask completed
    │       └── IhpColocatedTask completed
    │           └── IhpColocatedTask completed
    │               └── TimedHoldTask completed
    ├── JudgeDecisionReviewTask cancelled
    └── JudgeDecisionReviewTask assigned

# Looks like these probably stemmed from a reassign, given the cancelled JudgeDecisionReviewTask. Let's double check they all have a cancelled task
reassigned_jdr_tasks = jdr_tasks_without_atty_tasks.select { |task| task.appeal.tasks.cancelled.where(type: JudgeDecisionReviewTask.name).exists? }
 reassigned_jdr_tasks.count
=> 382
# Yup!

It would appear that all of these cases have a cancelled JudgeDecisionReviewTask, implying that these JudgeDecisionReviewTasks were reassigned after the AttorneyTask was completed. Currently, we only move open children to the new parent when we reassign a task.

AC

• Non cancelled AttorneyTasks should move to the new task when a JudgeDecisionReviewTask is reassigned
• Appeals in this state in production are fixed

Notes

Could possibly look into simply moving all children to the new parent on task reassign, or just non cancelled children

[ajspotts]

What is this graph?

1 | 
2 | 
3 | ||||||||||||
5 | 
8 |  

Good team knowledge around this space. Quite a bit of work, folks with less familiarity may glean some good info here.

[pkarman]

fyi researching this for the original ticket I wrote this AR query that may help identify existing data problem:

JudgeDecisionReviewTask.cancelled
  .joins(:children).where(children_tasks: { status: Constants.TASK_STATUSES.completed })
  .joins(:parent).where(parents_tasks: { status: Constants.TASK_STATUSES.completed})
  .count

see https://github.com/department-of-veterans-affairs/dsva-vacols/issues/99#issuecomment-587577959 et al

[hschallhorn]

Fixed here. Waiting for response here to ensure this is fixed