Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motion to Vacate | Success banner after AddressMotionToVacate task is submitted #13073

Closed
1 task
leikkisa opened this issue Dec 30, 2019 · 5 comments
Closed
1 task

Motion to Vacate | Success banner after AddressMotionToVacate task is submitted #13073

leikkisa opened this issue Dec 30, 2019 · 5 comments
Assignees
@jcq
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊

Comments

@leikkisa
Copy link
Contributor

leikkisa commented Dec 30, 2019 •
edited
Loading

User or job story

User story: As a Judge, after I submit an AddressMotionToVacate task, when I am redirected to queue I'd like to see a success banner.

Acceptance criteria

  • The "Disposition saved" success banner shows on the next page after the judge submits an AddressMotionToVacate

Tech notes

See PostDecisionMotionController.

The banner is currently being displayed elsewhere later (it's shown up in a couple of different pages). We believe it's because the page is not actually refreshing from the server, which is where the flash message is coming from.

It may be worth having the routing do a fresh refresh when redirecting to the Queue page, or otherwise seeing how these alerts are used elsewhere in the Queue app.
@leikkisa leikkisa added Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Dec 30, 2019
@leikkisa
Copy link
Contributor Author

@geronimoramos @rutvigupta-design Do you have a design for this success banner, or do you have opinions on the copy above?

@Sjones352 Sjones352 self-assigned this Jan 17, 2020
@msj0nes msj0nes changed the title Success banner after AddressMotionToVacate task is submitted Motion to Vacate | Success banner after AddressMotionToVacate task is submitted Jan 23, 2020
@leikkisa
Copy link
Contributor Author

I think this banner might exist, but that it wasn't getting triggered at the correct time.

@Sjones352 Sjones352 removed their assignment Jan 29, 2020
@msj0nes msj0nes mentioned this issue Feb 5, 2020
Closed
@jcq jcq self-assigned this Feb 21, 2020
@jcq
Copy link
Contributor

jcq commented Feb 21, 2020 •
edited
Loading

@rutvigupta-design What should the "detail" message be for this alert?

I'm setting the title to "Disposition Saved", but I need to override the detail (smaller text) with something

The default "detail" copy for success alerts on judge queue page apparently is
If you need to make any changes, please manage this case in DAS.

@rutvigupta-design
Copy link

rutvigupta-design commented Feb 21, 2020 •
edited
Loading

@jcq Attaching designs for the success banner for denied and dismissed motions.
Judge-Deny-Success
Judge-Dismiss-Success

@rutvigupta-design
Copy link

@jcq here is the banner for granted motions (full or partial vacaturs).
Judge-Grant-Success

@jcq jcq mentioned this issue Feb 21, 2020
Merged
2 tasks
va-bot pushed a commit that referenced this issue Feb 21, 2020
@jcq
Success Alert upon Completion of JudgeAddressMotionToVacate (#13509)
1754536 
Connects #13073

### Description
We now display success alerts at the top of judge's queue upon completion of `AddressMotionToVacate` task. This also removes the flash message that was being displayed when going back to the appeal detail page, as that should not have been happening.

### Acceptance Criteria
- [ ] Code compiles correctly
- [ ] Success alert shows upon successful completion of `AddressMotionToVacate`
@leikkisa leikkisa mentioned this issue Feb 25, 2020
Closed
@leikkisa leikkisa closed this as completed Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcq jcq

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jcq @leikkisa @Sjones352 @rutvigupta-design