Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Motions to Vacate | Testing Review | Engineering Corrections Required Post-UAT #13003

Closed
4 of 6 tasks
msj0nes opened this issue Dec 17, 2019 · 9 comments
Closed
4 of 6 tasks
Assignees
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊

Comments

@msj0nes
Copy link

msj0nes commented Dec 17, 2019

Story

Update to:
As a Lit Support team member (commonly Motions Attorney, but keeping Lit Support team member to encompass other Lit Support roles we might not know about yet), I need to be able to assign a task to the judge who will decide the Motion to Vacate decision.

UAT Findings
[Removed 'A']

  • B) Misspelling of 'Review'
  • C) Verbiage should change depending on radio selection made "Provide context on which issues should be [user radio button selection]
  • D) "Return to motions attorney" should also show when the judge selects "dismiss"

image

Acceptance criteria

  • Add header above the context comment/note provided in [A] (ask Rutvi and Geronimo for suggestion)
  • Word spelling highlighted in item [B] should be updated to reflect 'Review'
  • Upon user radio button selection [grant, deny, dismiss] highlighted in [C] please associate each radio button with copy below
    - For grant "Provide context on which issues should be granted"
    - For deny "Provide context on which issues should be denied"
    - For dismissed "Provide context on which issues should be dismissed"
  • Show "Return to Motions Attorney" options when "dismiss" is selected
  • Additional context not required unless granted is selected (submit is not disabled)
  • Add "required" label to context field when it is required

Release notes

N/A

Out of scope

N/A

Designs

https://www.figma.com/file/VtOG0hibbyJ6T5UcYnn5EP/Motions-to-Vacate_Phase-II_Epic-8547?node-id=0%3A1

Background/context

N/A

Technical notes

N/A

Other notes

Resources/other links

@msj0nes msj0nes added Team: Foxtrot 🦊 Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Stakeholder: OIT New requirements gathered by Geoffrey/Office of Information & Technology Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Dec 17, 2019
@msj0nes msj0nes changed the title UAT Update | Litigation Support Motion Attorney | Send_to_Judge Motions to Vacate | Motion Attorney | UAT Fix Jan 23, 2020
@jcq jcq self-assigned this Jan 23, 2020
@jcq
Copy link
Contributor

jcq commented Jan 23, 2020

@msj0nes @leikkisa
A couple of questions here:

  • "Return to Motions Attorney" isn't applicable to this view, right? This is the attorney screen, prior to it getting to the judge
  • Are we adding some sort of text (as noted in first AC), or is this stating that we want to leave out the context/instructions from the display (noted as "A" in the image)?

@msj0nes
Copy link
Author

msj0nes commented Jan 23, 2020

@jcq

"Return to Motions Attorney" isn't applicable to this view, right? This is the attorney screen, prior to it getting to the judge

'Return to motion attorney' is actually after the judge addresses the task, it gets returned to Lit Support (Motion Atty) . The issue is referring to the message seen below. As shown currently the radio button for 'deny' shows the message seen, however for dismiss it does not.

@jcq
Copy link
Contributor

jcq commented Jan 23, 2020

@msj0nes I think that's actually a screen grab from the judge (AddressMotionToVacate) task. That is indeed the functionality in the MTVJudgeDisposition component. If I'm understanding correctly, we want to display that message for both denied and dismissed dispositions on the "judge address motion" view. Would it be OK if we split that off into a separate ticket since it's a different component/view?

@msj0nes
Copy link
Author

msj0nes commented Jan 23, 2020

@jcq @leikkisa just created a ticket #13243

@leikkisa
Copy link
Contributor

@jcq We want to leave the context/instructions in the display, but make it optional for granted

@msj0nes
Copy link
Author

msj0nes commented Jan 23, 2020

@jcq removed 'A' . Its aesthetic and can be dealt with later on.

@jcq
Copy link
Contributor

jcq commented Jan 23, 2020

@jcq We want to leave the context/instructions in the display, but make it optional for granted

Oh, just to be clear I was referring to the context/instructions for the current attorney task, not the text field for the attorney to fill out. The context/instructions for the current task are what show at the top (indicated as "A"). I agree that there likely is no reason to have them there, and likely will never exist.

@jcq
Copy link
Contributor

jcq commented Jan 23, 2020

Updated UX:

MotionsAttorneyDisposition-updates

va-bot pushed a commit that referenced this issue Jan 23, 2020
Connects #13003

### Description
This makes a number of UI/UX changes & fixes to `MotionsAttorneyDisposition` and related components.

### Acceptance Criteria
- [ ] Add header above the context comment/note provided in [A] (ask Rutvi and Geronimo for suggestion)
- [ ] Word spelling highlighted in item [B] should be updated to reflect 'Review'
- [ ] Upon user radio button selection [grant, deny, dismiss] highlighted in [C] please associate each radio button with copy below
          - For grant "Provide context on which issues should be granted"
          - For deny "Provide context on which issues should be denied"
          - For dismissed "Provide context on which issues should be dismissed"
- [ ] Show "Return to Motions Attorney" options when "dismiss" is selected
- [ ] Additional context not required unless granted is selected (submit is not disabled)
- [ ] Add "required" label to context field when it is required

### Testing Plan
```
export REACT_ON_RAILS_ENV=HOT; bundle exec rspec spec/feature/queue/motion_to_vacate_spec.rb:99
```

### User Facing Changes

 - [ ] Screenshots of UI changes added to PR & Original Issue
@msj0nes msj0nes removed the Stakeholder: OIT New requirements gathered by Geoffrey/Office of Information & Technology label Feb 2, 2020
@msj0nes
Copy link
Author

msj0nes commented Feb 5, 2020

Much appreciated @jcq

@msj0nes msj0nes closed this as completed Feb 5, 2020
@msj0nes msj0nes changed the title Motions to Vacate | Motion Attorney | UAT Fix Motions to Vacate | Testing Review | Fix Feb 5, 2020
@msj0nes msj0nes changed the title Motions to Vacate | Testing Review | Fix Motions to Vacate | Testing Review | Engineering Corrections Required Post-UAT Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊
Projects
None yet
Development

No branches or pull requests

4 participants