Handle undefined attorney in app/queue/AssignedCasesPage.jsx

[yoomlam]

Description

In app/queue/AssignedCasesPage.jsx , an error occurs when an attorney is not found and thus is undefined. Handle this case better: app/queue/AssignedCasesPage in full_name: Cannot read property 'full_name' of undefined

Background/context/resources

During Bat Teaming, Sentry alert occurred: https://dsva.slack.com/archives/CLRTL92TW/p1576600351014300

Sentry alert: https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/7605/

Technical notes

const attorneyName = attorneysOfJudge.filter((attorney) => attorney.id.toString() === attorneyId)[0].full_name;

initiated by ./app/queue/QueueActions.js in dispatch at line 372

[hschallhorn]

https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/7686/?query=is%3Aunresolved%20%22app%2Fqueue%2FAssignedCasesPage%20in%20full_name%22

[hschallhorn]

What is this graph?

1 | 
2 | ||||||||||
3 | ||||
5 | 
8 |  

Timebox this to a two as it has only occurred twice to a couple of users.

[jcq]

https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/8849/

FYI, while this issue is marked as low priority, it is preventing me from loading the case assignment page mentioned in that sentry alert. I assume this is likely a large issue for that particular user.

If you like shiny new things, this might be a good candidate for using the optional chaining and/or nullish coalescing operators.

[hschallhorn]

Prioritize'd! Thanks for bringing this up!

[yoomlam]

I'm able to replicate and see the error in the console by going to an acting judge (who doesn't have attorneys) and manually entering http://localhost:3000/queue/BVAACTING/assign/88 (the resulting page is blank). I can also replicate as a judge trying to view an attorney who is not on my team by manually changing the URL: http://localhost:3000/queue/BVAAABSHIRE/assign/92.

@jcq Can you describe how I can replicate the error you described as:

it is preventing me from loading the case assignment page mentioned in that sentry alert.

Looking at all of these Sentry alerts, it seems like the user must be modifying or pasting the URL because none of the attorney links on the side panel corresponds to the URLs trying to be reached.

[yoomlam]

BEFORE	AFTER PR
(blank screen; unhandled error in devtools)

[hschallhorn]

Based on the breadcrumbs of these alerts it looks like this could be a stale link the user has bookmarked?

Clicking the link on the judge assign page	Modifying the url

+ 88
+ tasks?user_id=3&role=Judge
+ 3
+ users?role=Attorney
+ users?role=Attorney&judge_id=3
+ BVAAABSHIRE
88?role=judge
tasks?user_id=88&role=attorney
BVAEERDMAN?role=judge

[jcq]

@jcq Can you describe how I can replicate the error you described as:

it is preventing me from loading the case assignment page mentioned in that sentry alert.

Sorry, missed this until now. That said, it looks like Yoom identified the issue in the intervening time, as your before/after shots demonstrate. The "before" shot shows the issue I encountered as that user.

[hschallhorn]

I agree that we should handle this more gracefully, but I'm not sure the judge being unable to access this page is a concern. The attorney is not on their team, so they should not be able to see the attorney's cases.

[yoomlam]

My PR will restrict judges from viewing other judge's assign queue. Once we enable the CM (case movement) feature flag (:scm_view_judge_assign_queue), then CM users will be able to view any judge's assign queue.

Ann-Marie sent a note to the Board noting that we are fixing the bug (judge's being able to see other JudgeTeam's assign queue).

complete convo

[hschallhorn]

I didn't realize these were related. We confirmed that a judge viewing another judge's queue is what is causing the error? I don't have any errors showing in this scenario

Random attorney viewing a judge assign queue with scm_view_judge_assign_queue turned off (as it is in production)

Random attorney viewing an attorney's queue within a judge assigmn queue with scm_view_judge_assign_queue turned off (as it is in production)

[yoomlam]

I was able recreate error by logging in as judges as described in prior comment. I did not test when logged in as an attorney.

So back on the master branch, I test as an attorney.
Logging in as BVASCASPER1 (who is in JudgeTeam BVAOSCHOWALT), I go to
http://localhost:3000/queue/BVAGSPORER/assign/92 and get the 403 status from the tasks_controller but the page is not blank:

When I go to http://localhost:3000/queue/BVAAABSHIRE/assign/92, I don't get the 403 status, but the page is blank:

Feature flag scm_view_judge_assign_queue is not active:

---

On the PR branch and logged in as BVASCASPER1, I get this error page for those two URLs:

[yoomlam]

Updated error message:

BEFORE	AFTER
(blank screen; unhandled error in devtools)	(Atty 92 is not part of BVAAABSHIRE's JudgeTeam), (Atty 92 is part of BVAGSPORER's JudgeTeam, which BVAAABSHIRE is not a part of)