Determine what to do with children of cancelled tasks assigned to inactive users #12505

hschallhorn · 2019-10-29T18:32:01Z

Spun out of #12483.

In some scenarios, when we "reassign" tasks of an inactive user, some tasks are merely cancelled to be reassigned manually by a judge, team admin, quality reviewer, bva dispatch team member, etc. On occasion these tasks will have children that become orphaned due to their parent being cancelled. In some scenarios, these children can be moved to their new parent. In other scenarios, these downstream children should be cancelled.

This ticket exists to determine which path to take in which situation.

AC

Plan to handle children of cancelled tasks is created
Properly handling these children is specced out with another ticket(s) to do the work

lomky · 2019-10-31T19:12:57Z

Throwing a 2 at this after scoping it to planning out the work needed.

Resolves #12394 ### Description Reassigns all tasks assigned to a user ### Acceptance Criteria - [ ] Fails when original tasks are not in the correct state - [ ] Leaves all reassigned tasks in the correct state ### Testing Plan Users to test: - BVAAABSHIRE (Parent task is RootTask assigned to Bva) - QR_USER (Parent task assigned to `Organization` NOT using automatic child task assignment) - CSS_ID1 (Parent task assigned to `Organization` using automatic child task assignment) - BVASCASPER1 (Parent task assigned to `User` - `AttorneyTask`) _All of this was done off of a fresh `make reset`_ #### BVAAABSHIRE 1. Check out the state of the user's current tasks ```ruby user = User.find_by(css_id: "BVAAABSHIRE") user.update_status!(Constants.USER_STATUSES.inactive) JudgeTeam.for_judge(user).non_admins.each do |atty| OrganizationsUser.add_user_to_organization(user, JudgeTeam.first) end JudgeQualityReviewTask.create!(parent: QualityReviewTask.active.last, assigned_to: user, appeal: QualityReviewTask.active.last.appeal) appeals = Task.open.where(assigned_to: user).order(:type, :status).map(&:appeal) task_trees = appeals.map do |appeal| appeal.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # assigned JudgeAssignTask # Appeal 114 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── DistributionTask 4, completed # └── JudgeAssignTask 3, assigned # assigned JudgeDecisionReviewTask with completed AttorneyTask # Appeal 50 [assigned_to_id, status] # └── RootTask 4, on_hold # └── JudgeDecisionReviewTask 3, assigned # └── AttorneyTask 1, completed # on hold JudgeDecisionReviewTask with downstream children # Appeal 111 [assigned_to_id, status] # └── RootTask 4, on_hold # └── JudgeDecisionReviewTask 3, on_hold # └── AttorneyTask 1, on_hold # └── TranslationColocatedTask 10, on_hold # └── TranslationTask 10, assigned # on hold JudgeDecisionReviewTask # Appeal 60 [assigned_to_id, status] # └── RootTask 4, on_hold # └── JudgeDecisionReviewTask 3, on_hold # └── AttorneyTask 1, in_progress # JudgeQualityReviewTask (parent assigned to user) # Appeal 17 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── DistributionTask 4, assigned # ├── JudgeDecisionReviewTask 53, completed # │ └── AttorneyTask 54, completed # └── QualityReviewTask 11, on_hold # └── QualityReviewTask 46, on_hold # └── JudgeQualityReviewTask 3, assigned ``` 2. Rake! ```bash bundle exec rake tasks:reassign_from_user[3,false] ``` 3. Check the state of the reassigned tasks ```ruby Task.open.where(assigned_to: user).count # => 0 appeals.map do |appeal| appeal.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # assigned JudgeAssignTask # Appeal 114 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── DistributionTask 4, completed # ├── JudgeAssignTask 3, cancelled # └── DistributionTask 4, assigned # assigned JudgeDecisionReviewTask with completed AttorneyTask # Appeal 50 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # └── JudgeDecisionReviewTask 82, assigned # └── AttorneyTask 1, completed # on hold JudgeDecisionReviewTask with downstream children # Appeal 111 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # └── JudgeDecisionReviewTask 82, on_hold # └── AttorneyTask 1, on_hold # └── TranslationColocatedTask 10, on_hold # └── TranslationTask 10, assigned # on hold JudgeDecisionReviewTask # Appeal 60 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # └── JudgeDecisionReviewTask 82, on_hold # └── AttorneyTask 1, in_progress # JudgeQualityReviewTask (parent assigned to user) # Appeal 17 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── DistributionTask 4, assigned # ├── JudgeDecisionReviewTask 53, completed # │ └── AttorneyTask 54, completed # └── QualityReviewTask 11, on_hold # └── QualityReviewTask 46, assigned # └── JudgeQualityReviewTask 3, cancelled # ✅ Judge tasks assigned to user are cancelled # ✅ Judge assign tasks are put back into distribution # ✅ new JudgeDecisionReviewTasks are created for another judge # ✅ AttorneyTasks are under their new parent # ✅ JudgeQualityReviewTask is cancelled with an "assigned" parent ``` #### QR_USER 1. Check out the state of the user's current tasks ```ruby user = User.find_by(css_id: "QR_USER") appeals = Task.open.where(assigned_to: user).order(:type, :status).map(&:appeal) appeals.map do |appeal| appeal.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # Appeal 17 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── DistributionTask 4, assigned # ├── JudgeDecisionReviewTask 53, completed # │ └── AttorneyTask 54, completed # └── QualityReviewTask 11, on_hold # └── QualityReviewTask 46, assigned ``` 2. Rake! ```bash bundle exec rake tasks:reassign_from_user[46,false] ``` 3. Check the state of the reassigned tasks ```ruby Task.open.where(assigned_to: user).count # => 0 appeals.map do |appeal| appeal.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # Appeal 17 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── DistributionTask 4, assigned # ├── JudgeDecisionReviewTask 53, completed # │ └── AttorneyTask 54, completed # └── QualityReviewTask 11, assigned # └── QualityReviewTask 46, cancelled # ✅ Tasks assigned to user are cancelled # ✅ Organization task is reopened for admin to assign ``` #### CSS_ID1 1. Check out the state of the user's current tasks ```ruby user = User.find_by(css_id: "CSS_ID1") user.update_status!(Constants.USER_STATUSES.inactive) org_tasks = Task.open.where(assigned_to: user).order(:type, :status).map(&:parent) org_tasks.map do |parent| parent.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # AddressVerificationColocatedTask 5, on_hold # └── AddressVerificationColocatedTask 15, assigned # MissingRecordsColocatedTask 5, on_hold # └── MissingRecordsColocatedTask 15, assigned # StayedAppealColocatedTask 5, on_hold # └── StayedAppealColocatedTask 15, assigned ``` 2. Rake! ```bash bundle exec rake tasks:reassign_from_user[15,false] ``` 3. Check the state of the reassigned tasks ```ruby Task.open.where(assigned_to: user).count # => 0 org_tasks.map do |parent| parent.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # AddressVerificationColocatedTask 5, on_hold # ├── AddressVerificationColocatedTask 15, cancelled # └── AddressVerificationColocatedTask 16, assigned # MissingRecordsColocatedTask 5, on_hold # ├── MissingRecordsColocatedTask 15, cancelled # └── MissingRecordsColocatedTask 16, assigned # StayedAppealColocatedTask 5, on_hold # ├── StayedAppealColocatedTask 15, cancelled # └── StayedAppealColocatedTask 16, assigned # ✅ Tasks assigned to user are cancelled # ✅ Organization task is still on hold # ✅ Another task of the same type has been opened for other colocated team members ``` #### BVASCASPER1 1. Check out the state of the user's current tasks ```ruby user = User.find_by(css_id: "BVASCASPER1") appeals = Task.open.where(assigned_to: user).order(:type, :status).map(&:appeal) appeals.map do |appeal| appeal.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # in progress Task # Appeal 60 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # └── JudgeDecisionReviewTask 82, on_hold # └── AttorneyTask 1, in_progress # on hold Task # Appeal 96 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # └── JudgeDecisionReviewTask 82, on_hold # └── AttorneyTask 1, on_hold # └── HearingClarificationColocatedTask 5, on_hold # └── HearingClarificationColocatedTask 16, assigned ``` 2. Rake! ```bash bundle exec rake tasks:reassign_from_user[1,false] ``` 3. Check the state of the reassigned tasks ```ruby Task.open.where(assigned_to: user).count # => 0 appeals.map do |appeal| appeal.structure_render(:assigned_to_id, :status) end.each { |tree| puts tree } # in progress Task # Appeal 60 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # │ └── AttorneyTask 1, cancelled # └── JudgeAssignTask 3, assigned # on hold Task # Appeal 96 [assigned_to_id, status] # └── RootTask 4, on_hold # ├── JudgeDecisionReviewTask 3, cancelled # │ └── AttorneyTask 1, cancelled # │ └── HearingClarificationColocatedTask 5, on_hold # │ └── HearingClarificationColocatedTask 16, assigned # └── JudgeAssignTask 3, assigned # ✅ AttorneyTasks and JudgeDecisionReviewTasks are cancelled # ✅ New JudgeAssignTask created ``` TODO: - [x] Fix `JudgeDecisionReviewTask` reassign - [x] Add test instructions for other users - [x] Reassess tasks with parents assigned to other users - [x] Determine what to do with downstream children (ticketed #12505)

araposo-tistatech · 2020-04-09T12:52:12Z

@hschallhorn,

Can you confirm the below are the only parent/child task associations we will run into in this case?

“PARENT TASK”, “CHILD TASK”
[[“JudgeAssignTask”, “AttorneyTask”],
[“JudgeDispatchReturnTask”, “AttorneyDispatchReturnTask”],
[“BvaDispatchTask”, “JudgeDispatchReturnTask”],
[“QualityReviewTask”, “JudgeQualityReviewTask”],
[“JudgeDecisionReviewTask”, “AttorneyTask”],
[“JudgeDecisionReviewTask”, “AttorneyRewriteTask”],
[“JudgeQualityReviewTask”, “AttorneyQualityReviewTask”]]

hschallhorn · 2020-04-20T18:05:49Z

hschallhorn · 2020-04-20T18:43:26Z

araposo-tistatech · 2020-04-22T19:51:07Z

@hschallhorn can you explain what you mean by the first option "Move the orphaned child tasks to the parent task"? My moving it to the parent task do you mean moving it to the user that has that parent task?

hschallhorn · 2020-04-22T20:06:38Z

Here is an example!

Currently: Say an attorney leaves the board and there is a AttorneyDispatchReturnTask assigned to them that will now be cancelled and it has a downstream OtherColocatedTask (admin action). This would make the parent JudgeDispatchReturnTask "assigned" and able to be assigned to a different attorney, but leaves an open OtherColocatedTask. This could leave us with a colocated task that never gets completed before the appeal is dispatched.

Proposed: "Move the orphaned child tasks to the parent task" means we will make that JudgeDispatchReturnTask the parent of the previously orphaned OtherColocatedTask tasks. VLJ support an continue working this OtherColocatedTask and the judge can assign the a AttorneyDispatchReturnTask to a new attorney once the admin action is completed.

Task trees

BEFORE REASSIGN

Appeal 17635 (direct_review)                    STATUS    ASGN_TO
└── RootTask                                    on_hold   Bva
    └── BvaDispatchTask                         on_hold   BvaDispatch
        └── BvaDispatchTask                     on_hold   VACOWILLIW
            └── JudgeDispatchReturnTask         on_hold   VACOCARACA
                └── AttorneyDispatchReturnTask  on_hold   VACOPARKT
                    └── OtherColocatedTask      on_hold   Colocated
                        └── OtherColocatedTask  assigned  VACOAUSTIT1

AFTER CANCELLING (CURRENT)

Appeal 17635 (direct_review)                    STATUS    ASGN_TO
└── RootTask                                    on_hold   Bva
    └── BvaDispatchTask                         on_hold   BvaDispatch
        └── BvaDispatchTask                     on_hold   VACOWILLIW
            └── JudgeDispatchReturnTask         assigned  VACOCARACA
                └── AttorneyDispatchReturnTask  cancelled VACOPARKT
                    └── OtherColocatedTask      on_hold   Colocated     <- Orphaned 
                        └── OtherColocatedTask  assigned  VACOAUSTIT1   <- tasks

AFTER CANCELLING (PROPOSED)

Appeal 17635 (direct_review)                    STATUS    ASGN_TO
└── RootTask                                    on_hold   Bva
    └── BvaDispatchTask                         on_hold   BvaDispatch
        └── BvaDispatchTask                     on_hold   VACOWILLIW
            └── JudgeDispatchReturnTask         on_hold   VACOCARACA
                ├── AttorneyDispatchReturnTask  cancelled VACOPARKT
                └── OtherColocatedTask          on_hold   Colocated
                    └── OtherColocatedTask      assigned  VACOAUSTIT1

araposo-tistatech · 2020-05-12T17:57:16Z

@hschallhorn regrets, realized I did not add the Boards thoughts to this ticket. They agree with the first two suggestions and would like for the colocated tasks to remain active even if the cases is assigned back to distribution.

araposo-tistatech · 2020-07-16T14:09:17Z

@hschallhorn please let me know if further definition is needed here.

hschallhorn · 2020-07-16T17:59:07Z

would like for the colocated tasks to remain active even if the cases is assigned back to distribution

The open question is where these should move to. If they remain where they are, the case could be dispatched without the work being completed. If the move to under the distribution task, they will block distribution.

araposo-tistatech · 2020-08-13T20:18:13Z

Sent email to the Board inquire where the colocated tasks should move to.

araposo-tistatech · 2020-08-26T18:17:32Z

What is the concern of having the colocated tasks block distribution? The Board feels this might be the better option since the attorney and/or VLJ would not be able to work the case until those are completed anyway, but they will confirm this with the DVCs.

hschallhorn · 2020-08-26T21:06:29Z

That is true! If that's what the board would like moving forward, that works for me! Happy to finally have a resolution for this

hschallhorn · 2020-08-26T21:19:16Z

hschallhorn added Team: Echo 🐬 inactive-users labels Oct 29, 2019

hschallhorn mentioned this issue Oct 29, 2019

Create rake task to reassign all tasks assigned to a user #12483

Merged

6 tasks

hschallhorn added the Priority: High Escalations from Support, blocking issue/NO workaround, or "first in" priority for new work. label Oct 30, 2019

lpciferri removed the inactive-users label Oct 30, 2019

lomky mentioned this issue Nov 4, 2019

Echo engineering team lines of effort #7556

Closed

araposo-tistatech added the Product: caseflow-queue label Apr 2, 2020

hschallhorn added Feature: generic-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Type: Investigation labels Apr 22, 2020

hschallhorn closed this as completed Aug 26, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Determine what to do with children of cancelled tasks assigned to inactive users #12505

Determine what to do with children of cancelled tasks assigned to inactive users #12505

hschallhorn commented Oct 29, 2019 •

edited

Loading

lomky commented Oct 31, 2019

araposo-tistatech commented Apr 9, 2020

hschallhorn commented Apr 20, 2020 •

edited

Loading

hschallhorn commented Apr 20, 2020

araposo-tistatech commented Apr 22, 2020

hschallhorn commented Apr 22, 2020

araposo-tistatech commented May 12, 2020

araposo-tistatech commented Jul 16, 2020

hschallhorn commented Jul 16, 2020

araposo-tistatech commented Aug 13, 2020

araposo-tistatech commented Aug 26, 2020 •

edited

Loading

hschallhorn commented Aug 26, 2020

hschallhorn commented Aug 26, 2020 •

edited

Loading

Determine what to do with children of cancelled tasks assigned to inactive users #12505

Determine what to do with children of cancelled tasks assigned to inactive users #12505

Comments

hschallhorn commented Oct 29, 2019 • edited Loading

AC

lomky commented Oct 31, 2019

araposo-tistatech commented Apr 9, 2020

hschallhorn commented Apr 20, 2020 • edited Loading

hschallhorn commented Apr 20, 2020

araposo-tistatech commented Apr 22, 2020

hschallhorn commented Apr 22, 2020

Task trees

araposo-tistatech commented May 12, 2020

araposo-tistatech commented Jul 16, 2020

hschallhorn commented Jul 16, 2020

araposo-tistatech commented Aug 13, 2020

araposo-tistatech commented Aug 26, 2020 • edited Loading

hschallhorn commented Aug 26, 2020

hschallhorn commented Aug 26, 2020 • edited Loading

hschallhorn commented Oct 29, 2019 •

edited

Loading

hschallhorn commented Apr 20, 2020 •

edited

Loading

araposo-tistatech commented Aug 26, 2020 •

edited

Loading

hschallhorn commented Aug 26, 2020 •

edited

Loading