Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CM: Add Judge & Attorney Selectors to JudgeTeam Team Page #12433

Closed
3 tasks
lomky opened this issue Oct 18, 2019 · 1 comment · Fixed by #13191
Closed
3 tasks

CM: Add Judge & Attorney Selectors to JudgeTeam Team Page #12433

lomky opened this issue Oct 18, 2019 · 1 comment · Fixed by #13191
Assignees
@ajspotts
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬

Comments

@lomky
Copy link
Contributor

lomky commented Oct 18, 2019 •
edited by jimruggiero
Loading

Give JudgeTeam Admins the ability to flag users as Judge or Attorneys on the JudgeTeam page

Acceptance Criteria

  • JudgeTeam page has the ability to flag users as Judge, Attorney.
  • Functionality is tied to feature flag.
  • Please include one or more screenshots when complete.

Part of #11801
@lpciferri lpciferri mentioned this issue Oct 18, 2019
Closed
@lomky
Copy link
Contributor Author

lomky commented Nov 14, 2019

What is this graph?

1 | 
2 | |||
3 | |||||||||||||
5 | ||
8 |

Estimating at a 3. Possibly a 2 as its largely making a front end update to match the back end. Possibly a 5 as it cleaves off a whole new page, and we need new controllers. A lot of code, straightforward, but a lot. This particular component doesn't currently care about what organization it is, possibly keep that knowledge of this being a judgeteam on the backend, rather than having the front end duplicate the knowledge. Possibly duplicate the work frontend/backend now to make this easier for now?

Add copy about what being admin for a JudgeTeam means!

@lomky lomky mentioned this issue Dec 2, 2019
Closed
@hschallhorn hschallhorn mentioned this issue Jan 16, 2020
Closed
@ajspotts ajspotts mentioned this issue Jan 17, 2020
Merged
7 tasks
@jimruggiero jimruggiero added Product: caseflow-queue Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests labels Jan 23, 2020
va-bot pushed a commit that referenced this issue Jan 28, 2020
@ajspotts
Alec/12433 add judge and atty selectors to judgeteam page (#13191)
4f9db91 
Resolves #12433

### Description

- `OrganizationsUsers` page has the ability to recognize and properly render a Judge Team.  
- A Judge Team admin can add and remove the Decision Drafting Attorney role from users on the team.  
- Labels identifying the assigned roles of each user (Judge Team Lead, Decision Drafting Attorney & Admin) as well as descriptions of those roles are displayed for user clarity.

### Acceptance Criteria
#### Frontend
- [ ] JudgeTeam page has the ability to assign and remove Decision Drafting Attorney role to team members
- [ ] Labels representing assigned roles for each user are displayed
- [ ] Changes do not modify appearance of other organizations' pages

#### Backend
- [ ] `Organizations::UsersController` accepts `attorney` params and updates the `DecisionDraftingAttorney` role via the `OrganizationsUser` model
- [ ] Roles are properly retrieved via an update to `administered_user_serializer`
- [ ] Functionality is tied to feature flag

#### Additional Changes
- [ ] Ensure Admin role button properly working via updates to the following models: `make_user_admin` in `organizations_user` and `add_user` in `judge_team` 

BEFORE
<img width="1225" alt="Screen Shot 2020-01-16 at 4 47 55 PM" src="https://user-images.githubusercontent.com/18618189/72568058-3b01c900-3885-11ea-8d3d-4ccd2fee2d5d.png">

AFTER
![judge_team](https://user-images.githubusercontent.com/18618189/72569719-08f26600-3889-11ea-92e4-74623c5f910c.gif)

### Testing Plan
1. Login as Judge BVAAABSHIRE and navigate to the team management page http://localhost:3000/organizations/bvaaabshire/users
2. Ensure the "Enable Decision Drafting" button gives a user the role of "Decision Drafting Attorney"
3. Ensure the "Disable Decision Drafting" button removes "Decision Drafting Attorney" role from user
@araposo-tistatech araposo-tistatech changed the title SCM: Add Judge & Attorney Selectors to JudgeTeam Team Page CM: Add Judge & Attorney Selectors to JudgeTeam Team Page Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajspotts ajspotts

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Echo 🐬
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Alec/12433 add judge and atty selectors to judgeteam page department-of-veterans-affairs/caseflow
3 participants
@lomky @ajspotts @jimruggiero