Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Motion to Vacate | Do not show actions for MTV Judge tasks on_hold #12412

Closed
leikkisa opened this issue Oct 16, 2019 · 0 comments · Fixed by #12549
Closed

Motion to Vacate | Do not show actions for MTV Judge tasks on_hold #12412

leikkisa opened this issue Oct 16, 2019 · 0 comments · Fixed by #12549
Assignees
@nanotone @Sjones352
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊

Comments

@leikkisa
Copy link
Contributor

leikkisa commented Oct 16, 2019 •
edited
Loading

User or job story

As a Judge user, when my motions to vacate tasks are on hold, I shouldn't be able to perform actions on them.

Open questions

Was the default "on_hold" behavior overwritten in JudgeTask on purpose? Please check with the person who created "actions_available?" in JudgeTask, or someone who is familiar with the desired behavior for one of the other judge tasks. Another potential place to look for an answer is the specs.

Acceptance criteria

  • A Judge cannot perform actions on their MTV tasks while they are on hold, unless it is a timed hold (default task behavior)
    • JudgeAddressMotionToVacateTask
    • JudgeSignMotionToVacateTask
  • Update top line comments in JudgeTask with the MTV JudgeTasks

Technical notes

  • The default task behavior in "actions_available?" is to not show actions if the task is on_hold (unless it's a timed hold)
  • This was overwritten in JudgeTask, which is a parent of the above two tasks
  • Depending on the answer to the open question above, if it was on purpose, this can be implemented for the two specific tasks. If it wasn't, then it can be for all Judge tasks (this may fix a bug). If we don't know, the default path forward is to only apply it to the MTV tasks.

Release notes

N/A

Designs

N/A

Background/context

Discussion thread for whether on_hold tasks should have actions:
https://dsva.slack.com/archives/C2ZAMLK88/p1571268452113200
@leikkisa leikkisa self-assigned this Oct 16, 2019
@leikkisa leikkisa changed the title Limit actions available for on_hold tasks Remove available actions for MTV Judge tasks on_hold Oct 17, 2019
@leikkisa leikkisa changed the title Remove available actions for MTV Judge tasks on_hold Do not show actions for MTV Judge tasks on_hold Oct 17, 2019
@leikkisa leikkisa added Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. labels Oct 17, 2019
@leikkisa leikkisa removed their assignment Oct 28, 2019
@nanotone nanotone mentioned this issue Nov 1, 2019
Merged
3 tasks
va-bot pushed a commit that referenced this issue Nov 4, 2019
@nanotone
Remove actions on on-hold tasks for judges (#12549)
de20a2d 
Resolves #12412 

### Description
Removes `JudgeTask`'s `actions_available?` method so that it reverts to the default implementation, which is to return false when the task is on hold. I consulted with @tomas-nava who is more familiar with this area and believes the override was an out-of-date work-around that's no longer needed.

### Acceptance Criteria
- [ ] A Judge cannot perform actions on their MTV tasks while they are on hold, unless it is a timed hold (default task behavior)
- [ ] Update top line comments in JudgeTask with the MTV JudgeTasks

### Testing Plan
- [ ] Manual smoke-test to confirm that judges' on-hold tasks do not allow any actions (the default behavior)

### Documentation Updates
- Updated topline comment in `judge_task.rb` to reflect the new MTV subclasses
@nanotone nanotone reopened this Nov 4, 2019
@leikkisa leikkisa mentioned this issue Nov 13, 2019
Closed
@msj0nes msj0nes changed the title Do not show actions for MTV Judge tasks on_hold Motion to Vacate | Do not show actions for MTV Judge tasks on_hold Feb 5, 2020
@msj0nes msj0nes mentioned this issue Feb 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanotone nanotone

@Sjones352 Sjones352

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Stakeholder: BVA Functionality associated with the Board of Veterans' Appeals workflows/feature requests Team: Foxtrot 🦊
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove actions on on-hold tasks for judges department-of-veterans-affairs/caseflow
3 participants
@nanotone @leikkisa @Sjones352