Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent MailRoutingErrors from triggering Sentry alerts #10615

Closed
1 task
lowellrex opened this issue Apr 30, 2019 · 2 comments · Fixed by #12155
Closed
1 task

Prevent MailRoutingErrors from triggering Sentry alerts #10615

lowellrex opened this issue Apr 30, 2019 · 2 comments · Fixed by #12155
Assignees
@lowellrex
Labels
Feature: generic-queue Product: caseflow-queue Source: Sentry Alert created because of a Sentry alert Team: Echo 🐬 Type: Bug

Comments

@lowellrex
Copy link
Contributor

Longer term fix is #10614, but in the short-term we can prevent MailRoutingErrors like this one by catching them in the TasksController (or ApplicationController) and returning the serialized error without sending it to Sentry.

Acceptance criteria

  • Prevent MailRoutingErrors from triggering Sentry alerts
@lowellrex
Copy link
Contributor Author

SMALL.

@pkarman pkarman added the Source: Sentry Alert created because of a Sentry alert label May 28, 2019
@hschallhorn
Copy link
Contributor

This as well https://sentry.ds.va.gov/department-of-veterans-affairs/caseflow/issues/6389/

@hschallhorn hschallhorn mentioned this issue Sep 9, 2019
Closed
@lowellrex lowellrex self-assigned this Sep 18, 2019
@lowellrex lowellrex mentioned this issue Sep 18, 2019
Merged
va-bot pushed a commit that referenced this issue Sep 18, 2019
@lowellrex
Prevent MailRoutingErrors from triggering Sentry alerts (#12155)
baba8e1 
Resolves #10615. Catch `MailRoutingError`s in the controller so that we don't send the error to Sentry as we previously were by relying on the [error catching logic in `ApplicationController`](https://github.com/department-of-veterans-affairs/caseflow/blob/8f168920a70b82899c28b4e99e2551774c1c0c64/app/controllers/application_controller.rb#L12).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lowellrex lowellrex

Labels
Feature: generic-queue Product: caseflow-queue Source: Sentry Alert created because of a Sentry alert Team: Echo 🐬 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent MailRoutingErrors from triggering Sentry alerts department-of-veterans-affairs/caseflow
3 participants
@pkarman @lowellrex @hschallhorn