Wrap cancel tree in transaction

department-of-veterans-affairs · Jan 16, 2020 · cb7a19b · cb7a19b
1 parent 776150b
commit cb7a19b
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/app/models/task.rb b/app/models/task.rb
@@ -533,12 +533,15 @@ def cancel_task_and_child_subtasks
     # by avoiding callbacks, we aren't saving PaperTrail versions
     # Manually save the state before and after.
     tasks = Task.open.where(id: descendant_ids)
-    tasks.each { |task| task.paper_trail.save_with_version }
-    tasks.update_all(
-      status: Constants.TASK_STATUSES.cancelled,
-      closed_at: Time.zone.now
-    )
-    tasks.each { |task| task.reload.paper_trail.save_with_version }
+
+    transaction do
+      tasks.each { |task| task.paper_trail.save_with_version }
+      tasks.update_all(
+        status: Constants.TASK_STATUSES.cancelled,
+        closed_at: Time.zone.now
+      )
+      tasks.each { |task| task.reload.paper_trail.save_with_version }
+    end
   end
 
   def timeline_title