ABD-VRO/909: GitHub Actions: Send and attach "Failure" message to deploy workflow Slack message on any error #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in React to top-level notification step
yoomlam
suggested changes
Jan 10, 2023
There was a problem hiding this comment.
Looks great! For the happy path, it looks like the Slack notifications are in the failure state.
yoomlam
reviewed
Jan 11, 2023
yoomlam
reviewed
Jan 11, 2023
yoomlam
reviewed
Jan 11, 2023
yoomlam
suggested changes
Jan 11, 2023
yoomlam
approved these changes
Jan 13, 2023
alan-amida
added a commit
that referenced
this pull request
Jan 23, 2023
* Fix typo: slackExceptionWebhook (#918) * MCP-2218 Add category for conditions (#908) * filter for encounter diagnosis * add category to condition * add category to condition * fix python tests * add try except Co-authored-by: julianbregstone <julian> * Notify Slack when deploy scripts run (#919) * add notify-slack.src * have deploy-app,core,db,mq,redis.sh use notify-slack.sh * Mcp 2009 - update BIP API Service (#910) * Update BipApiService. * Change default setting for ENV=dev to BIP UAT instead of mocker service, per Afsin. Co-authored-by: dimitri-amida <[email protected]> Co-authored-by: Afsin Ustundag <[email protected]> * MCP-2123 - Basic sanitization of Request Body JSON input (#912) * Basic sanitization of Request Body JSON input * Cleanup * Consistent Javadocs and clarification for GlobalExceptionHandler * Fix verbiage from Unallowed to Disallowed * Add end2endTest for JSON RequestBody sanitizing * Refactor Pattern.compile to class-level field 2 * Fix typo * MCP-2233 Python Health Check (#930) Python healthcheck * MCP-1153 Health Check for Lighthouse Service Container (#933) * health check for lighthouse service container * correct the end point for health check * eol last line Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: dimitri-amida <[email protected]> * Notify deploys in GH Action Slack thread (#924) * remove GITHUB_ACCESS_TOKEN requirement * specify SLACK_CHANNEL in case it changes * remove unnecessary secrets.USERNAME * remove GITHUB_ACCESS_TOKEN requirement for other deploy-*.sh scripts * remove extraneous DEPLOY_STATE_TEXT * Remove references to yoomlam's GH PAT (#925) * replace secrets.ACCESS_TOKEN with secrets.GITHUB_TOKEN * revert secrel.yml * comment out SecRel4's use of secrets.GITHUB_TOKEN * Ensures that only one deploy per env will run at a time * Add BIP keystore and truststore, add BIP evidence api test endpoint. (#934) * Add BIP keystore and truststore, add BIP evidence api test endpoint. * undo Intellij's change in previous commit. * Lower the test code coverage for testing the lint-and-test error. * Reversed the previous code coverage change. * 1. Add BipFileUploadPayload data values in BipClaimService; 2. Increase app test code coverage by 1%; 3. Reduce BIP related environment variables (TODO notes in scripts/setenv.sh); 4. Adjust deployment.yml to reflect the env variable settings in the cluster. * Address PR review comments. * Add empty line at the end, per review comments. * Adjust BipApiConfigTest to avoid the dependence on ENV variable setup. Co-authored-by: Afsin Ustundag <[email protected]> * use an existing role for postgres health check (#938) Co-authored-by: Afsin Ustundag <[email protected]> * MCP-2110 PDF Generate + Fetch Queue (#871) * PDF Generate + Fetch * update queue * immediate pdf Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: dimitri-amida <[email protected]> * update config merge * fix port * management port * Clean up Helm Chart.yaml files * ABD-VRO/909: GitHub Actions: Send and attach "Failure" message to deploy workflow Slack message on any error (#922) * Delay deploy Slack notification to allow notify-push-to-branch to post first * MCP-2240 Un-parsable date fix (#939) * add edge case handler * add unparsed flag * cleanup logic Co-authored-by: julianbregstone <julian> Co-authored-by: Anthony Velazquez <[email protected]> * MCP-2230 persist claim (#928) * MCP-2230: added collectionId * MCP-2230: persist claim * MCP-2230: fixed contentions bug * MCP-2230: spotless * MCP-2230: added tests * MCP-2230: removed unused file * MCP-2230: separate request from processing object * Bump pytest-mock-resources from 2.6.5 to 2.6.6 (#948) Bumps [pytest-mock-resources](https://github.com/schireson/pytest-mock-resources) from 2.6.5 to 2.6.6. - [Release notes](https://github.com/schireson/pytest-mock-resources/releases) - [Changelog](https://github.com/schireson/pytest-mock-resources/blob/main/CHANGELOG.md) - [Commits](schireson/pytest-mock-resources@v2.6.5...v2.6.6) --- updated-dependencies: - dependency-name: pytest-mock-resources dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> * MCP-2245 Update RFD sufficiency logic (#949) * change number of required readings * fix tests * more explicit condition Co-authored-by: julianbregstone <julian> Co-authored-by: Anthony Velazquez <[email protected]> * Bump pytest from 7.2.0 to 7.2.1 (#947) Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.2.0 to 7.2.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.2.0...7.2.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> * Bump redis from 4.4.1 to 4.4.2 (#946) Bumps [redis](https://github.com/redis/redis-py) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@v4.4.1...v4.4.2) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> * Bump httpclient from 4.5 to 4.5.14 (#944) Bumps httpclient from 4.5 to 4.5.14. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump jedis-mock from 1.0.5 to 1.0.6 (#942) Bumps [jedis-mock](https://github.com/fppt/jedis-mock) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/fppt/jedis-mock/releases) - [Commits](fppt/jedis-mock@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: com.github.fppt:jedis-mock dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pytz from 2022.7 to 2022.7.1 (#945) * Bump pytz from 2022.7 to 2022.7.1 Bumps [pytz](https://github.com/stub42/pytz) from 2022.7 to 2022.7.1. - [Release notes](https://github.com/stub42/pytz/releases) - [Commits](stub42/pytz@release_2022.7...release_2022.7.1) --- updated-dependencies: - dependency-name: pytz dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * merge fix Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> Co-authored-by: Julian Bregstone <[email protected]> * add environment variables to service * MCP-2247: fix NPE in BipClaimService (#951) * MCP-2247: fix NPE * MCP-2247: use BipException for consistency * Mcp 2182 - Fix swagger doc errors (#954) Fix swagger doc error, MCP-2182, MCP-2263. * add configs for sandbox * MCP-2262 Use new PDF endpoint (#961) * MCP-2247: fix NPE * MCP-2262: Avoid NPE if no special issues * MCP-2262: Avoid NPE if no special issues * MCP-2262: Process PDF using the "instant" version * MCP-2262: Persist evidence summary * MCP-2246 Reformat date (#950) * reformat date * merge fix * extract custom date function * fix tests * fix format Co-authored-by: julianbregstone <julian> Co-authored-by: Anthony Velazquez <[email protected]> * Mcp 2273 (#964) * 1. Fix broken endpoints in BIP controller. 2. Add messages to MockBipApiService responses to identify the responses from mocker. * Fix spotlessJava complaints. * Removed commented out logs, and old comments. Co-authored-by: Alan Thompson <[email protected]> * MCP-2211 Add 400 Bad Request responses to swagger list for MAS (#962) Add 400 Bad Request responses to swagger list for MAS Co-authored-by: Alan Thompson <[email protected]> * Remove temporary values-updated.yaml files * Bump pytest-mock-resources from 2.6.6 to 2.6.7 (#971) Bumps [pytest-mock-resources](https://github.com/schireson/pytest-mock-resources) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/schireson/pytest-mock-resources/releases) - [Changelog](https://github.com/schireson/pytest-mock-resources/blob/main/CHANGELOG.md) - [Commits](schireson/pytest-mock-resources@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: pytest-mock-resources dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Seth Darr <[email protected]> * Bump flyway/flyway from 9.11.0-alpine to 9.12.0-alpine in /db-init/src/docker (#969) Bump flyway/flyway in /db-init/src/docker Bumps flyway/flyway from 9.11.0-alpine to 9.12.0-alpine. --- updated-dependencies: - dependency-name: flyway/flyway dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julian Bregstone <[email protected]> * MCP-2223 PDF Documentation (#973) * documentation * Update service-python/pdfgenerator/README.md Co-authored-by: Julian Bregstone <[email protected]> Co-authored-by: Julian Bregstone <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Yoom Lam <[email protected]> Co-authored-by: Julian Bregstone <[email protected]> Co-authored-by: Warren Lin <[email protected]> Co-authored-by: dimitri-amida <[email protected]> Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: Anthony Velazquez <[email protected]> Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: advcoder <[email protected]> Co-authored-by: Aurora Hampton <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ianwolson <[email protected]> Co-authored-by: Seth Darr <[email protected]>
alan-amida
added a commit
that referenced
this pull request
Jan 26, 2023
* Fix typo: slackExceptionWebhook (#918) * MCP-2218 Add category for conditions (#908) * filter for encounter diagnosis * add category to condition * add category to condition * fix python tests * add try except Co-authored-by: julianbregstone <julian> * Notify Slack when deploy scripts run (#919) * add notify-slack.src * have deploy-app,core,db,mq,redis.sh use notify-slack.sh * Mcp 2009 - update BIP API Service (#910) * Update BipApiService. * Change default setting for ENV=dev to BIP UAT instead of mocker service, per Afsin. Co-authored-by: dimitri-amida <[email protected]> Co-authored-by: Afsin Ustundag <[email protected]> * MCP-2123 - Basic sanitization of Request Body JSON input (#912) * Basic sanitization of Request Body JSON input * Cleanup * Consistent Javadocs and clarification for GlobalExceptionHandler * Fix verbiage from Unallowed to Disallowed * Add end2endTest for JSON RequestBody sanitizing * Refactor Pattern.compile to class-level field 2 * Fix typo * MCP-2233 Python Health Check (#930) Python healthcheck * MCP-1153 Health Check for Lighthouse Service Container (#933) * health check for lighthouse service container * correct the end point for health check * eol last line Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: dimitri-amida <[email protected]> * Notify deploys in GH Action Slack thread (#924) * remove GITHUB_ACCESS_TOKEN requirement * specify SLACK_CHANNEL in case it changes * remove unnecessary secrets.USERNAME * remove GITHUB_ACCESS_TOKEN requirement for other deploy-*.sh scripts * remove extraneous DEPLOY_STATE_TEXT * Remove references to yoomlam's GH PAT (#925) * replace secrets.ACCESS_TOKEN with secrets.GITHUB_TOKEN * revert secrel.yml * comment out SecRel4's use of secrets.GITHUB_TOKEN * Ensures that only one deploy per env will run at a time * Add BIP keystore and truststore, add BIP evidence api test endpoint. (#934) * Add BIP keystore and truststore, add BIP evidence api test endpoint. * undo Intellij's change in previous commit. * Lower the test code coverage for testing the lint-and-test error. * Reversed the previous code coverage change. * 1. Add BipFileUploadPayload data values in BipClaimService; 2. Increase app test code coverage by 1%; 3. Reduce BIP related environment variables (TODO notes in scripts/setenv.sh); 4. Adjust deployment.yml to reflect the env variable settings in the cluster. * Address PR review comments. * Add empty line at the end, per review comments. * Adjust BipApiConfigTest to avoid the dependence on ENV variable setup. Co-authored-by: Afsin Ustundag <[email protected]> * use an existing role for postgres health check (#938) Co-authored-by: Afsin Ustundag <[email protected]> * MCP-2110 PDF Generate + Fetch Queue (#871) * PDF Generate + Fetch * update queue * immediate pdf Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: dimitri-amida <[email protected]> * update config merge * fix port * management port * Clean up Helm Chart.yaml files * ABD-VRO/909: GitHub Actions: Send and attach "Failure" message to deploy workflow Slack message on any error (#922) * Delay deploy Slack notification to allow notify-push-to-branch to post first * MCP-2240 Un-parsable date fix (#939) * add edge case handler * add unparsed flag * cleanup logic Co-authored-by: julianbregstone <julian> Co-authored-by: Anthony Velazquez <[email protected]> * MCP-2230 persist claim (#928) * MCP-2230: added collectionId * MCP-2230: persist claim * MCP-2230: fixed contentions bug * MCP-2230: spotless * MCP-2230: added tests * MCP-2230: removed unused file * MCP-2230: separate request from processing object * Bump pytest-mock-resources from 2.6.5 to 2.6.6 (#948) Bumps [pytest-mock-resources](https://github.com/schireson/pytest-mock-resources) from 2.6.5 to 2.6.6. - [Release notes](https://github.com/schireson/pytest-mock-resources/releases) - [Changelog](https://github.com/schireson/pytest-mock-resources/blob/main/CHANGELOG.md) - [Commits](schireson/pytest-mock-resources@v2.6.5...v2.6.6) --- updated-dependencies: - dependency-name: pytest-mock-resources dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> * MCP-2245 Update RFD sufficiency logic (#949) * change number of required readings * fix tests * more explicit condition Co-authored-by: julianbregstone <julian> Co-authored-by: Anthony Velazquez <[email protected]> * Bump pytest from 7.2.0 to 7.2.1 (#947) Bumps [pytest](https://github.com/pytest-dev/pytest) from 7.2.0 to 7.2.1. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/main/CHANGELOG.rst) - [Commits](pytest-dev/pytest@7.2.0...7.2.1) --- updated-dependencies: - dependency-name: pytest dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> * Bump redis from 4.4.1 to 4.4.2 (#946) Bumps [redis](https://github.com/redis/redis-py) from 4.4.1 to 4.4.2. - [Release notes](https://github.com/redis/redis-py/releases) - [Changelog](https://github.com/redis/redis-py/blob/master/CHANGES) - [Commits](redis/redis-py@v4.4.1...v4.4.2) --- updated-dependencies: - dependency-name: redis dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> * Bump httpclient from 4.5 to 4.5.14 (#944) Bumps httpclient from 4.5 to 4.5.14. --- updated-dependencies: - dependency-name: org.apache.httpcomponents:httpclient dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump jedis-mock from 1.0.5 to 1.0.6 (#942) Bumps [jedis-mock](https://github.com/fppt/jedis-mock) from 1.0.5 to 1.0.6. - [Release notes](https://github.com/fppt/jedis-mock/releases) - [Commits](fppt/jedis-mock@v1.0.5...v1.0.6) --- updated-dependencies: - dependency-name: com.github.fppt:jedis-mock dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump pytz from 2022.7 to 2022.7.1 (#945) * Bump pytz from 2022.7 to 2022.7.1 Bumps [pytz](https://github.com/stub42/pytz) from 2022.7 to 2022.7.1. - [Release notes](https://github.com/stub42/pytz/releases) - [Commits](stub42/pytz@release_2022.7...release_2022.7.1) --- updated-dependencies: - dependency-name: pytz dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * merge fix Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Anthony Velazquez <[email protected]> Co-authored-by: Julian Bregstone <[email protected]> * add environment variables to service * MCP-2247: fix NPE in BipClaimService (#951) * MCP-2247: fix NPE * MCP-2247: use BipException for consistency * Mcp 2182 - Fix swagger doc errors (#954) Fix swagger doc error, MCP-2182, MCP-2263. * add configs for sandbox * MCP-2262 Use new PDF endpoint (#961) * MCP-2247: fix NPE * MCP-2262: Avoid NPE if no special issues * MCP-2262: Avoid NPE if no special issues * MCP-2262: Process PDF using the "instant" version * MCP-2262: Persist evidence summary * MCP-2246 Reformat date (#950) * reformat date * merge fix * extract custom date function * fix tests * fix format Co-authored-by: julianbregstone <julian> Co-authored-by: Anthony Velazquez <[email protected]> * Mcp 2273 (#964) * 1. Fix broken endpoints in BIP controller. 2. Add messages to MockBipApiService responses to identify the responses from mocker. * Fix spotlessJava complaints. * Removed commented out logs, and old comments. Co-authored-by: Alan Thompson <[email protected]> * MCP-2211 Add 400 Bad Request responses to swagger list for MAS (#962) Add 400 Bad Request responses to swagger list for MAS Co-authored-by: Alan Thompson <[email protected]> * Remove temporary values-updated.yaml files * Bump pytest-mock-resources from 2.6.6 to 2.6.7 (#971) Bumps [pytest-mock-resources](https://github.com/schireson/pytest-mock-resources) from 2.6.6 to 2.6.7. - [Release notes](https://github.com/schireson/pytest-mock-resources/releases) - [Changelog](https://github.com/schireson/pytest-mock-resources/blob/main/CHANGELOG.md) - [Commits](schireson/pytest-mock-resources@v2.6.6...v2.6.7) --- updated-dependencies: - dependency-name: pytest-mock-resources dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Seth Darr <[email protected]> * Bump flyway/flyway from 9.11.0-alpine to 9.12.0-alpine in /db-init/src/docker (#969) Bump flyway/flyway in /db-init/src/docker Bumps flyway/flyway from 9.11.0-alpine to 9.12.0-alpine. --- updated-dependencies: - dependency-name: flyway/flyway dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julian Bregstone <[email protected]> * MCP-2223 PDF Documentation (#973) * documentation * Update service-python/pdfgenerator/README.md Co-authored-by: Julian Bregstone <[email protected]> Co-authored-by: Julian Bregstone <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Yoom Lam <[email protected]> Co-authored-by: Julian Bregstone <[email protected]> Co-authored-by: Warren Lin <[email protected]> Co-authored-by: dimitri-amida <[email protected]> Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: Anthony Velazquez <[email protected]> Co-authored-by: Afsin Ustundag <[email protected]> Co-authored-by: advcoder <[email protected]> Co-authored-by: Aurora Hampton <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: ianwolson <[email protected]> Co-authored-by: Seth Darr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Attaches the "Deployment Failure" message to the "Deployment Start" thread in slack.
Associated tickets or Slack threads:
How does this fix it?1
How to test this PR
-- 1. Cancel the job
-- 2. Cause an error (that may require writing something such as
exit 1in the tasks - this is how I tested it)-- 1. a "Deployment Cancelled" message if either of the jobs in the workflow were cancelled
-- 2. a "Deployment Failed!" message if either of the jobs in the workflow failed
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩