3528 add monitoring tags

[brostk]

What was the problem?

Monitoring tags are required by the VA but not present on metrics.

Associated tickets or Slack threads:

• Add monitor tags to svc-bip-api #3528

How does this fix it?[^1]

MetricLoggerService now includes all required tags with values populated by properties defined in application.yaml.

[github-actions]

Test Results

136 tests  ±0   136 ✅ ±0   19s ⏱️ ±0s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit c497fa7. ± Comparison against base commit ed95e6e.

♻️ This comment has been updated with latest results.

[github-actions]

JaCoCo Test Coverage

Overall Project	71.14% -0.87%	❌
Files changed	72.45%	❌

File	Coverage
IMetricLoggerService.java	100%	🍏
BipApiService.java	98.87%	🍏
BipRequestErrorHandler.java	88.12%	🍏
MetricLoggerService.java	84.15% -8.23%	❌
InvalidPayloadRejectingFatalExceptionStrategy.java	0%	🍏

[dfitchett]

The changes here propagate into the ContentionEventsListener class in the svc-bie-kafka and some of the tags will be duplicated. Can you extend your review to fix that as well?

[dfitchett]

Ah one other thing that is just a thought... what about making the metric prefix also part of this MetricLogger class and imported as a property?

[brostk]

The changes here propagate into the ContentionEventsListener class in the svc-bie-kafka and some of the tags will be duplicated. Can you extend your review to fix that as well?

This was your recent addition, right? Any objections to removing the tags here in favor of the common code addition in MetricLoggerService?

Ah one other thing that is just a thought... what about making the metric prefix also part of this MetricLogger class and imported as a property?

Looks plenty do-able, but it'll touch a few interfaces. Be prepared for a larger PR!

Also, the log.info statements when the metrics were successfully submitted should probably be debug not info

I can update these while I'm in the code.

[dfitchett]

LGTM! 🚀