rm unused redis #2905
Merged
rm unused redis #2905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msnwatson
force-pushed
the
mwatson/rm-unused-svcs
branch
from
ee46a79 to
4204dcd
Compare
msnwatson
force-pushed
the
mwatson/rm-unused-redis
branch
from
2ff8ecd to
d160c4c
Compare
JaCoCo Test Coverage
|
lisac
approved these changes
Apr 29, 2024
lisac
force-pushed
the
mwatson/rm-unused-redis
branch
from
dc62b34 to
58fe1c7
Compare
Ponnia-M
pushed a commit
that referenced
this pull request
Jul 22, 2024
* mv api gateway * run rabbit and redis on all profiles * run rabbit and redis on all profiles * rm unused redis * rm redis ref
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Redis was being configured, maintained, and deployed; however, it was not being used by any of our services.
To the reviewer, note there are no removals of any Redis client code within our applications as evidence that it was not being used.
Associated tickets or Slack threads:
How does this fix it?1
Unlike other PRs for this ticket, this does not correspond to the creation of a new repo. This is because LHDI has enabled the use of ElastiCache so that in the future, if we would like to use a Redis-like DataStore, it is not longer necessary for us to maintain our own instance.
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩