Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mv api gateway #2893

Merged
merged 5 commits into from
Apr 24, 2024
Merged

mv api gateway #2893

merged 5 commits into from
Apr 24, 2024

Conversation

msnwatson
Copy link
Contributor

@msnwatson msnwatson commented Apr 23, 2024 •
edited
Loading

What was the problem?

We're not using this service, and it is cluttering our repos, SecRel pipelines, and codebase.

Associated tickets or Slack threads:

How does this fix it?1

  • Moves the code to another repo which is linked on the homepage of our wiki

How to test this PR

  • Removing the deployment from escalating LHDI environments

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Test Results

137 tests  ±0   137 ✅ ±0   43s ⏱️ ±0s
 40 suites ±0     0 💤 ±0 
 40 files   ±0     0 ❌ ±0 

Results for commit cdfe3eb. ± Comparison against base commit d107e03.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

JaCoCo Test Coverage

Overall Project 76.03% ❌

There is no coverage information present for the Files changed

@msnwatson msnwatson marked this pull request as ready for review April 23, 2024 23:05
@msnwatson msnwatson requested a review from a team as a code owner April 23, 2024 23:05
lisac
lisac approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@lisac lisac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

I hadn't built my local dev in awhile. Pulled this branch and can confirm that it builds/runs in docker on local dev.

@msnwatson msnwatson force-pushed the mwatson/rm-unused-svcs branch from b161758 to e73074b Compare April 24, 2024 21:18
@msnwatson msnwatson merged commit afaa214 into develop Apr 24, 2024
1 check passed
@msnwatson msnwatson deleted the mwatson/rm-unused-svcs branch April 24, 2024 22:34
@msnwatson msnwatson restored the mwatson/rm-unused-svcs branch May 1, 2024 20:26
Ponnia-M pushed a commit that referenced this pull request Jul 22, 2024
@msnwatson @Ponnia-M
mv api gateway (#2893)
b7ec248 
* mv api gateway

* regen image_vars.srcs

* bump ruby-dev

* run rabbit and redis on all profiles

* run rabbit and redis on all profiles
@msnwatson msnwatson deleted the mwatson/rm-unused-svcs branch September 5, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisac lisac lisac approved these changes

@nelsestu nelsestu Awaiting requested review from nelsestu nelsestu is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

@Ponnia-M Ponnia-M Awaiting requested review from Ponnia-M

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msnwatson @lisac