Move svc-lighthouse-api to its own repo

[msnwatson]

What was the problem?

The titular service has not been used for over a year, cluttering the repo, our SecRel pipelines, and LHDI environments.

Associated tickets or Slack threads:

• remove some current deployments - second ticket-clean up LHDI #2697

How does this fix it?¹

• Moves the service into its own repo at https://github.com/department-of-veterans-affairs/abd-vro-svc-lighthouse-api

How to test this PR

• Remove deployments in escalating environments

Footnotes

1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

[github-actions]

Test Results

137 tests   - 14   137 ✅  - 14   42s ⏱️ -4s
 40 suites  -  6     0 💤 ± 0 
 40 files    -  6     0 ❌ ± 0 

Results for commit b3cd3a1. ± Comparison against base commit 8959174.

This pull request removes 14 tests.

gov.va.vro.abddataaccess.AppPropertiesTests ‑ testRabbitMqProperties()
gov.va.vro.abddataaccess.exception.AbdExceptionTest ‑ test()
gov.va.vro.abddataaccess.model.AbdResponseTest ‑ test()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testGetAbdEvidence()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testGetBloodPressure()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testGetMedicalEvidence()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testMedicalEvidenceEmptyBundles()
gov.va.vro.abddataaccess.service.FieldExtractorTest ‑ testBloodPressureMeasurement()
gov.va.vro.abddataaccess.service.FieldExtractorTest ‑ testExtractBloodPressure()
gov.va.vro.abddataaccess.service.FieldExtractorTest ‑ testExtractCondition()
…

♻️ This comment has been updated with latest results.

[github-actions]

JaCoCo Test Coverage

Overall Project	72.99%	❌

There is no coverage information present for the Files changed

[chengjie8]

LGTM

[lisac]

looks good to me. two questions, neither of which should hold up the PR.

1. the helm chart deploy.sh handles a case for svc-lighthouse-api - is that still needed?

   abd-vro/helm/deploy.sh

   Lines 83 to 84 in b3cd3a1

   	svc-lighthouse-api)
   	HELM_ARGS="$HELM_ARGS --set-string imageTag=$svclighthouseapi_VER ";;

2. should we re-generate image_vars.src to remove its references tosvc-lighthouse-api? for example:

   abd-vro/scripts/image_vars.src

   Line 8 in b3cd3a1

   VRO_IMAGES_ARR=( postgres redis rabbitmq api-gateway app db-init dev-tools svc-bgs-api svc-lighthouse-api svc-bie-kafka svc-bip-api xample-workflows cc-app ee-max-cfi-app ee-ep-merge-app )

if these are relevant, could be addressed in a follow-up PR.

[nelsestu]

Just what I'd expect to see. 6k removed 1 added

[msnwatson]

looks good to me. two questions, neither of which should hold up the PR.

1. the helm chart deploy.sh handles a case for svc-lighthouse-api - is that still needed?

   abd-vro/helm/deploy.sh

   Lines 83 to 84 in b3cd3a1

   	svc-lighthouse-api)
   	HELM_ARGS="$HELM_ARGS --set-string imageTag=$svclighthouseapi_VER ";;

2. should we re-generate image_vars.src to remove its references tosvc-lighthouse-api? for example:

   abd-vro/scripts/image_vars.src

   Line 8 in b3cd3a1

   VRO_IMAGES_ARR=( postgres redis rabbitmq api-gateway app db-init dev-tools svc-bgs-api svc-lighthouse-api svc-bie-kafka svc-bip-api xample-workflows cc-app ee-max-cfi-app ee-ep-merge-app )

if these are relevant, could be addressed in a follow-up PR.

Good catches, @lisac. Nothing would go wrong if we waited on these, but I'll go ahead and knock them out