Fix CC helm chart syntax #2863
Merged
Fix CC helm chart syntax #2863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaCoCo Test Coverage
|
… env variables? why: trying to figure out whether introducing the postgres and alembic env variables is causing the deployment failure. these were introduced since the last successful build.
why: consistency with how the other env vars are pulled in, and it contains postgresUrl. if we bring in just the postgresUrl, then for syntax purposes we might need to write out the key name POSTGRES_URL.
why: deployment is complaining about a nil pointer at this spot hard-coded the value found in helm/_shared/values.yaml#L8 .
error message:
> error calling include: [...] _helpers.tpl:15:26 executing "vro.annotations.pod" at <.Values.global.images.repo>: nil pointer evaluating interface {}.repo
https://github.com/department-of-veterans-affairs/abd-vro/blob/main/helm/_shared/values.yaml#L8
why: deployment is now complaining about nil pointer in this spot. something unusual about the `.Values.global.images.repo` lookup?
> error calling include: [...]_image.tpl:7:49: executing "vro.imageRegistryPath" at <.Values.global.images.repo>: nil pointer evaluating interface {}.repo
oops. in adding a `--debug`, i missed an important character.
the underlying issue is addressed in 056e689
group the vro.* values together, for readability
lisac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
Associated tickets or Slack threads:
How does this fix it?1
This PR results in a valid helm chart being generated.
defineblock (was missing the closingend)postgresUrlvaluesvro.dbClient.envVarsrather than single out thepostgresUrl. why: consistency with how other deployments in this repo. example:abd-vro/helm/domain-ee-ep-merge-app/templates/deployment.yaml
Line 31 in f434279
abd-vro/helm/domain-xample/templates/deployment.yaml
Line 29 in f434279
How to test this PR
helm upgradestep does not raise a parse errorFootnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩
To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline. ↩