-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP Merge: Wait for EP400 contentions #2700
Conversation
… max of 30 attempts. Updated unit/integration/end2end tests.
JaCoCo Test Coverage
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff! Just a few suggestions.
domain-ee/ee-ep-merge-app/src/python_src/service/ep_merge_machine.py
Outdated
Show resolved
Hide resolved
domain-ee/ee-ep-merge-app/src/python_src/service/ep_merge_machine.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed you left some occurrences of retry_rate
; wanna rename them all while you're at it? Also open to keeping this as-is if you had a reason.
Anyway, approving this 👍
What was the problem?
Contentions are not available immediately upon receipt of a merge requests.
Associated tickets or Slack threads:
How does this fix it?1
Changes allow retrying to get the contentions every 2 seconds for up to a minute.
How to test this PR
export BIP_CLAIM_URL=mock-bip-claims-api:20300
COMPOSE_PROFILES="bip,bgs" ./gradlew :app:dockerComposeUp
COMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp
./gradlew :domain-ee:ee-ep-merge-app:endToEndTest
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩