-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EP Merge: Fixed issue with created_at being incorrectly set. #2695
Conversation
JaCoCo Test Coverage
|
052aa37
to
78c8d16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Give that suggestion a spin and see how it goes. If it doesn't work, we can stick with the hard way.
b54f7f8
to
2345e6e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the one suggestion but this looks good.
What was the problem?
create_at
time was not being set correctly resulting in inaccurate duration times.How does this fix it?1
Made create_at time initialized on instance construction.
How to test this PR
export BIP_CLAIM_URL=mock-bip-claims-api:20300
COMPOSE_PROFILES="bip,bgs" ./gradlew :app:dockerComposeUp
COMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp
./gradlew :domain-ee:ee-ep-merge-app:endToEndTest
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩