Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP Merge: Fixed issue with created_at being incorrectly set. #2695

Merged
merged 7 commits into from
Mar 2, 2024

Conversation

dfitchett
Copy link
Contributor

What was the problem?

create_at time was not being set correctly resulting in inaccurate duration times.

How does this fix it?1

Made create_at time initialized on instance construction.

How to test this PR

  • pull code
  • Unit Test:
    • from /domain-ee/ee-ep-merge-app run pytest
  • Integration Tests:
    • run base platform
    • from /domain-ee/ee-ep-merge-app run pytest ./integration
  • End to End tests:
    • run this CI action to verify successful integration test
    • run end to end tests locally:
      • export BIP_CLAIM_URL=mock-bip-claims-api:20300
      • run bgs and bip services and mocks:
        • COMPOSE_PROFILES="bip,bgs" ./gradlew :app:dockerComposeUp
        • COMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp
      • ./gradlew :domain-ee:ee-ep-merge-app:endToEndTest

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@dfitchett dfitchett requested a review from a team as a code owner February 29, 2024 20:49
Copy link
Contributor

github-actions bot commented Feb 29, 2024

Test Results

149 tests  ±0   149 ✅ ±0   47s ⏱️ ±0s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit f5e15d0. ± Comparison against base commit 113f8cc.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 29, 2024

JaCoCo Test Coverage

Overall Project 76.57%

There is no coverage information present for the Files changed

@dfitchett dfitchett force-pushed the dfitchett/ep-merge/duration-fix branch from 052aa37 to 78c8d16 Compare February 29, 2024 22:14
Copy link
Contributor

@nanotone nanotone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Give that suggestion a spin and see how it goes. If it doesn't work, we can stick with the hard way.

@dfitchett dfitchett force-pushed the dfitchett/ep-merge/duration-fix branch from b54f7f8 to 2345e6e Compare March 1, 2024 18:18
Copy link
Contributor

@nanotone nanotone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one suggestion but this looks good.

@dfitchett dfitchett merged commit f6d4550 into develop Mar 2, 2024
1 check passed
@dfitchett dfitchett deleted the dfitchett/ep-merge/duration-fix branch March 2, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants