Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP Merge: Special Issue Code workaround for testing #2645

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

dfitchett
Copy link
Contributor

@dfitchett dfitchett commented Feb 21, 2024

What was the problem?

Due to testing constraints, the special issue code EMP is currently not working in UAT/sandbox environment (vets-api/VRO), this allows us to switch out the EMP special issue code for testing by using an environment variable.

Associated tickets or Slack threads:

How does this fix it?1

Changes allow getting special issue code from the environment variable EP_MERGE_SPECIAL_ISSUE_CODE, otherwise uses the code "EMP".

How to test this PR

  • pull code
  • Unit Test:
    • from /domain-ee/ee-ep-merge-app run pytest
  • Integration Tests:
    • run base platform
    • from /domain-ee/ee-ep-merge-app run pytest ./integration
  • End to End tests:
    • run this CI action to verify successful integration test
    • run end to end tests locally:
      • export BIP_CLAIM_URL=mock-bip-claims-api:20300
      • run bgs and bip services and mocks:
        • COMPOSE_PROFILES="bip,bgs" ./gradlew :app:dockerComposeUp
        • COMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp
      • ./gradlew :domain-ee:ee-ep-merge-app:endToEndTest

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@dfitchett dfitchett requested a review from a team as a code owner February 21, 2024 00:48
@dfitchett dfitchett requested a review from nanotone February 21, 2024 00:48
Copy link
Contributor

github-actions bot commented Feb 21, 2024

Test Results

149 tests  ±0   149 ✅ ±0   45s ⏱️ -3s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit 8f64a32. ± Comparison against base commit 422f591.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Feb 21, 2024

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 75.98%

Copy link
Contributor

@nanotone nanotone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

I assume it's pretty straightforward for us to update the environment variables that get sent into the app?

@dfitchett
Copy link
Contributor Author

Looks great!

I assume it's pretty straightforward for us to update the environment variables that get sent into the app?

Yeah, VRO team has changed some env variables for me in the past. So it shouldn't be an issue.

@dfitchett dfitchett merged commit 8c8a89c into develop Feb 23, 2024
1 check passed
@dfitchett dfitchett deleted the dfitchett/ep-merge/temp-special-issue branch February 23, 2024 17:01
agile-josiah pushed a commit that referenced this pull request Mar 1, 2024
Made special issue code an environment variable, so it can be switched without code change.
chengjie8 added a commit that referenced this pull request Apr 17, 2024
* Initial attempt currently failing on sasl handshake

* Enables sasl_ssl for our kafka broker and clients

* More changes

* Fix for integration test

* Remove comments and unnecessary duplication of ssl

* Automated commit: Unpin versions of updated images

* Bump org.springframework.boot:spring-boot-autoconfigure from 3.2.2 to 3.2.3 (#2659)

Bump org.springframework.boot:spring-boot-autoconfigure

Bumps [org.springframework.boot:spring-boot-autoconfigure](https://github.com/spring-projects/spring-boot) from 3.2.2 to 3.2.3.
- [Release notes](https://github.com/spring-projects/spring-boot/releases)
- [Commits](spring-projects/spring-boot@v3.2.2...v3.2.3)

---
updated-dependencies:
- dependency-name: org.springframework.boot:spring-boot-autoconfigure
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cheng <[email protected]>

* EP Merge: Special Issue Code workaround for testing (#2645)

Made special issue code an environment variable, so it can be switched without code change.

* Update QA BGS URL (#2622)

* Update to use vault values, added to dev and integration test yamls

* Update the remaining environments

* Updating the names of the topics and add the tls certs needed for communication.

* Add the var initialization to setenv.sh

* Update urls to dev from tst

* Update Contention Event to use new updated topic names

* Update BieMessagePayload to use new updated topic names

* Updating Login config to only include Kafka user and no default value

* Bump org.eclipse.jgit:org.eclipse.jgit from 6.8.0.202311291450-r to 6.9.0.202403050737-r (#2725)

Bump org.eclipse.jgit:org.eclipse.jgit

Bumps org.eclipse.jgit:org.eclipse.jgit from 6.8.0.202311291450-r to 6.9.0.202403050737-r.

---
updated-dependencies:
- dependency-name: org.eclipse.jgit:org.eclipse.jgit
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ponnia <[email protected]>

* Bump com.fasterxml.jackson.core:jackson-databind from 2.16.1 to 2.16.2 (#2728)

Bumps [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson) from 2.16.1 to 2.16.2.
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ponnia <[email protected]>

* Bump org.apache.commons:commons-compress from 1.26.0 to 1.26.1 (#2727)

Bumps org.apache.commons:commons-compress from 1.26.0 to 1.26.1.

---
updated-dependencies:
- dependency-name: org.apache.commons:commons-compress
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ponnia <[email protected]>

* Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 from 2.16.1 to 2.16.2 (#2726)

Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310

Bumps com.fasterxml.jackson.datatype:jackson-datatype-jsr310 from 2.16.1 to 2.16.2.

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.datatype:jackson-datatype-jsr310
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ponnia <[email protected]>

* EP Merge: Updated logging of errors and warnings (#2733)

* Updated logging of errors and warnings

* Simplify EP Merge integration test sorter (#2683)

Co-authored-by: Erik Nelsestuen <[email protected]>
Co-authored-by: Derek Fitchett <[email protected]>

* Github action version rollback (#2737)

* rollback version for yoomlam/delete-older-releases

* Revert "rollback version for yoomlam/delete-older-releases"

This reverts commit 19ad81e.

* rollback github-action version

* EPMerge: Fix serialization issue resulting in bad request response from BIP API (#2732)

Changed rest template to use configured objectmapper

* mock-bip-claims-api: Updated mocks for new EE EP Merge End2End tests. (#2746)

Updated mocks for new EE EP Merge End2End tests.

* EP Merge: add checks for get EP400 claim details (#2747)

* Added checks for EP 400 claim details to only allow claims with EP codes in [400, 409] with a benefit claim type code of '400SUPP'

* bump pydantic version for Contention Classification App (#2674)

bump pydantic version, use model validator w/ mode="before" for validating CfI

Co-authored-by: Erik Nelsestuen <[email protected]>

* #2749: PROD FIX, Increase rabbitmq container memory (#2750)

Production FIX: Increase the rabbitmq container memory

* Update SpringBootStarterWeb (#2752)

Snyk fix, update spring-boot-web to 3.2.3

* Upgrade spring-boot-starter-web package version  (#2754)

Upgrade spring-boot-starter-web package version

* remove all versioning (#2741)

* remove all versioning

* undo some changes

* run image-names script

* add back sourcing file

* Update the substring env instead of a prefix for bia kafka topics.

* Experiment with bie-kafka-end2end-test.yml

* Experiment with bie-kafka-end2end-test.yml

* Experiment with bie-kafka-end2end-test.yml

* Update group-id

* Add V02 to the end of topic names

* Update the escaped ""

* Changes to the key and value -deserializer

* Changes to the key and value -deserializer

* Add deserializer delegate class

* Add deserializer delegate class

* Fix integration test attempt #1

* Update kafka cert generation script to only generate the truststore.

* Add yes back

* Revert config

* Update application yamls

* Debug application integration test yaml

* Changes to bie kafka docker vars

* Changes to bie kafka docker vars

* Changes to bie kafka docker vars

* Add truststore back

* Edits to ssl/sasl connection

* Updates to docker-entryprep.sh to ignore the keystore creation/verification

* Remove references to keystore file

* Add a ssl piece to the properties file

* Add ssl truststore everywhere.

* Change shape of schema.registry.truststore.*

* Add in USER_INFO basic auth for schema registry

* Revert higher environments for RBAC to match develop

* Small nits and update to infix from env

* rm unnecessary Kafka cert gen

* Add qa and sandbox as well

* Revert mock BIE kafka to existing state

* Revert local config

* RBAC user id password are not needed for local test

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Cheng <[email protected]>
Co-authored-by: VRO Machine User <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Derek Fitchett <[email protected]>
Co-authored-by: Mason Watson <[email protected]>
Co-authored-by: Ponnia <[email protected]>
Co-authored-by: YANG YANG <[email protected]>
Co-authored-by: Erik Nelsestuen <[email protected]>
Co-authored-by: Luke Short <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants