#2582 Another round of datadog env vars #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Applying updated environment variables in support of datadog python api client naming expectations.
msnwatson
approved these changes
Feb 14, 2024
msnwatson
pushed a commit
that referenced
this pull request
Feb 15, 2024
Applying updated environment variables in support of datadog python api client naming expectations. Co-authored-by: Erik Nelsestuen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying updated environment variables in support of datadog python api client naming expectations. datadog_api_client/configuration.py
Includes a new script for populating the vro-datadog secret, with support for TARGET_ENV. The script expects to be executed from the repository's root directory
abd_vro> ./scripts/set-datadog-secret.sh TARGET_ENV DATADOG_API_KEY DATADOG_API_KEY_IDWhat was the problem?
Environment variables did not match what the datadog python api client expects.
Associated tickets or Slack threads:
How does this fix it?1
We are now setting DD_SITE, DD_API_KEY and DD_APP_KEY as the python client expects.
How to test this PR
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩