Switched DogStatsD for datadog_api_client to submit metrics

[dfitchett]

What was the problem?

DogStatsD is not supported by LHDI infrastructure due to security concerns.

Associated tickets or Slack threads:

• slack

How does this fix it?¹

This switches out the implementation for metric logging to use Datadog REST API instead of the python DogStatsD.

How to test this PR

• pull code
• Unit Test:
  • from /domain-ee/ee-ep-merge-app run pytest
• Integration Tests:
  • run base platform
  • from /domain-ee/ee-ep-merge-app run pytest ./integration
• End to End tests:
  • run this CI action to verify successful integration test
  • run end to end tests locally:
    • export BIP_CLAIM_URL=mock-bip-claims-api:20300
    • run bgs and bip services and mocks:
      • COMPOSE_PROFILES="bip,bgs" ./gradlew :app:dockerComposeUp
      • COMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp
    • ./gradlew :domain-ee:ee-ep-merge-app:endToEndTest

Footnotes

1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

[github-actions]

Test Results

129 tests  +6   125 ✅ +9   39s ⏱️ ±0s
 33 suites +2     0 💤 ±0 
 33 files   +2     4 ❌  - 3 

For more details on these failures, see this check.

Results for commit 1815a27. ± Comparison against base commit 517313a.

This pull request removes 7 and adds 13 tests. Note that renamed tests count towards both.

gov.va.vro.mockbipce.DocumentTypesTest ‑ getDocumentTypesTest()
gov.va.vro.mockbipce.FilesTest ‑ postFilesInvalidFolderUrlTest()
gov.va.vro.mockbipce.FilesTest ‑ postFilesNoFolderUrlTest()
gov.va.vro.mockbipce.FilesTest ‑ postFilesPositiveTest()
gov.va.vro.mockbipce.FilesTest ‑ postFilesWrongIdTypeTest()
gov.va.vro.mockbipce.JwtTest ‑ invalidJwtSecretTest()
gov.va.vro.mockbipce.JwtTest ‑ noJwtTest()

gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testCancelClaimById_NotFound()
gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testCancelClaimById_Success()
gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testGetClaimById_NotFound()
gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testGetClaimById_Success()
gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testPutTemporaryStationOfJurisdiction_InternalServerError()
gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testPutTemporaryStationOfJurisdiction_NotFound()
gov.va.vro.mockbipclaims.ClaimsControllerTest ‑ testPutTemporaryStationOfJurisdiction_Success()
gov.va.vro.mockbipclaims.ContentionsTest ‑ claim1010ContentionTest()
gov.va.vro.mockbipclaims.JwtTest ‑ invalidJwtSecretTest()
gov.va.vro.mockbipclaims.JwtTest ‑ noJwtTest()
…

[nanotone]

LGTM. This is so annoying though 🙃

By the way, just to double-check: it shouldn't be a problem that the underlying network implementation changed from UDP to TCP, right? Because ep_merge_machine.py isn't async anyway until it needs to fire off a make_request to hoppy.

[dfitchett]

LGTM. This is so annoying though 🙃

By the way, just to double-check: it shouldn't be a problem that the underlying network implementation changed from UDP to TCP, right? Because ep_merge_machine.py isn't async anyway until it needs to fire off a make_request to hoppy.

Hopefully not an issue. There is an async client that we could use, but the whole state machine including this call is running in a background thread already in the task created in job_runner.py.