Refactored JobState to have shorter names #2556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanotone
approved these changes
Feb 6, 2024
| SET_TEMP_STATION_OF_JURISDICTION_FAILED_REMOVE_SPECIAL_ISSUE = 'SET_TEMP_STATION_OF_JURISDICTION_FAILED_REMOVE_SPECIAL_ISSUE' | ||
| MOVE_CONTENTIONS_FAILED_REMOVE_SPECIAL_ISSUE = 'MOVE_CONTENTIONS_FAILED_REMOVE_SPECIAL_ISSUE' | ||
| MOVE_CONTENTIONS_FAILED_REVERT_TEMP_STATION_OF_JURISDICTION = 'MOVE_CONTENTIONS_FAILED_REVERT_TEMP_STATION_OF_JURISDICTION' | ||
| CANCEL_CLAIM_FAILED_REVERT_TEMP_STATION_OF_JURISDICTION = 'CANCEL_CLAIM_FAILED_REVERT_TEMP_STATION_OF_JURISDICTION' |
There was a problem hiding this comment.
This is so Java-ish but, then again, DRYing it up won't actually reduce the LoC count.
There was a problem hiding this comment.
Sorry can't help myself! 😆
raudabaugh
approved these changes
Feb 6, 2024
dfitchett
force-pushed
the
dfitchett/ep-merge/refactor-job-states
branch
from
9056674 to
08d9aae
Compare
nanotone
approved these changes
Feb 7, 2024
| """ | ||
| Uses the name as the automatic value, rather than an integer | ||
|
|
||
| See https://docs.python.org/3/library/enum.html#using-automatic-values for reference |
There was a problem hiding this comment.
Cute!
Yeah, this is a neat trick. This URL doesn't have the fragment for me though; https://docs.python.org/3/howto/enum.html#using-automatic-values is the one for me. 🤷
Base automatically changed from
dfitchett/ep-merge/black-formatter
to
develop
February 7, 2024 19:48
dfitchett
force-pushed
the
dfitchett/ep-merge/refactor-job-states
branch
from
49652c2 to
9cf7642
Compare
msnwatson
pushed a commit
that referenced
this pull request
Feb 15, 2024
* Refactored JobState to have shorter names * Fixed DRY code smell * Fixed url
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
JobStates were very long.
How does this fix it?1
JobState names will be shorter, resulting in shorter metric names, log statements, and db entries.
Stacked on PR
How to test this PR
export BIP_CLAIM_URL=mock-bip-claims-api:20300COMPOSE_PROFILES="bip,bgs" ./gradlew :app:dockerComposeUpCOMPOSE_PROFILES="bip,bgs" ./gradlew -p mocks :dockerComposeUp./gradlew :domain-ee:ee-ep-merge-app:endToEndTestFootnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩