Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commenting openssl command lines #2523

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Commenting openssl command lines #2523

merged 4 commits into from
Feb 1, 2024

Conversation

Ponnia-M
Copy link
Contributor

Commenting Openssl command lines relates to BGS-api issues

Associated tickets or Slack threads:

@Ponnia-M Ponnia-M requested a review from msnwatson January 31, 2024 23:16
@Ponnia-M Ponnia-M requested a review from a team as a code owner January 31, 2024 23:16
@msnwatson
Copy link
Contributor

I say let's go ahead and remove the lines completely for now

msnwatson
msnwatson reviewed Jan 31, 2024
View reviewed changes
Copy link
Contributor

@msnwatson msnwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

Test Results

148 tests  ±0   148 ✅ ±0   47s ⏱️ ±0s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit e44e1d2. ± Comparison against base commit 5435e4f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 31, 2024 •
edited
Loading

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.05% ❌

@Ponnia-M Ponnia-M merged commit 38bd8ba into develop Feb 1, 2024
1 check passed
@Ponnia-M Ponnia-M deleted the ponnia/bgs branch February 1, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msnwatson msnwatson msnwatson left review comments

@chengjie8 chengjie8 chengjie8 approved these changes

@nelsestu nelsestu Awaiting requested review from nelsestu nelsestu is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ponnia-M @msnwatson @chengjie8