-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add /claim-linker endpoint - log VBMS and VA.gov claim id's #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukey-luke
changed the title
Feature log vbms id as json
/claim-linker endpoint - log VBMS and VA.gov claim id's
Jan 9, 2024
lukey-luke
changed the title
/claim-linker endpoint - log VBMS and VA.gov claim id's
add /claim-linker endpoint - log VBMS and VA.gov claim id's
Jan 9, 2024
…d-as-json # Conflicts: # domain-cc/cc-app/src/python_src/api.py # domain-cc/cc-app/src/python_src/util/sanitizer.py
JaCoCo Test Coverage
|
msnwatson
approved these changes
Jan 12, 2024
tyler-spangler6
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
#2407
What was the problem?
VA.gov claim id is collected from /classifier, but VBMS id for the claim is not saved or linked to the va.gov claim presently.
Associated tickets or Slack threads:
How does this fix it?1
/claim-linker
How to test this PR
pytest
Footnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩