Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add /claim-linker endpoint - log VBMS and VA.gov claim id's #2432

Merged
merged 12 commits into from
Jan 12, 2024

Conversation

lukey-luke
Copy link
Contributor

@lukey-luke lukey-luke commented Jan 9, 2024

Depends on:
#2407

What was the problem?

VA.gov claim id is collected from /classifier, but VBMS id for the claim is not saved or linked to the va.gov claim presently.

Associated tickets or Slack threads:

How does this fix it?1

  • added endpoint for logging va.gov and vbms claim ids together /claim-linker

How to test this PR

  • pytest

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@lukey-luke lukey-luke changed the title Feature log vbms id as json /claim-linker endpoint - log VBMS and VA.gov claim id's Jan 9, 2024
@lukey-luke lukey-luke changed the title /claim-linker endpoint - log VBMS and VA.gov claim id's add /claim-linker endpoint - log VBMS and VA.gov claim id's Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Test Results

148 tests  ±0   148 ✅ ±0   50s ⏱️ +3s
 39 suites ±0     0 💤 ±0 
 39 files   ±0     0 ❌ ±0 

Results for commit 86fdb7e. ± Comparison against base commit 7e2bd1e.

♻️ This comment has been updated with latest results.

…d-as-json

# Conflicts:
#	domain-cc/cc-app/src/python_src/api.py
#	domain-cc/cc-app/src/python_src/util/sanitizer.py
@lukey-luke lukey-luke marked this pull request as ready for review January 11, 2024 18:34
@lukey-luke lukey-luke requested a review from a team as a code owner January 11, 2024 18:34
Copy link
Contributor

github-actions bot commented Jan 11, 2024

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.38%

@lukey-luke lukey-luke merged commit 1b7bd7c into develop Jan 12, 2024
1 check passed
@lukey-luke lukey-luke deleted the feature-log-vbms-id-as-json branch January 12, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants