Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EP Merge: Add error handling for remove special issues #2389

Merged

Conversation

dfitchett
Copy link
Contributor

What was the problem?

EP Merge needs to remove special issues on the EP400 if any of the following failures happen:

  • Get Pending Claim Details
  • Get Pending Claim Contentions
  • Set Temporary Station of Jurisdiction
  • Moving Contentions from EP400 to Pending EP
  • Cancel EP 400
  • Add Note via BGS

Associated Tickets/Slack Threads:

How does this fix it?1

Adds step in state machine to remove the special issue in those those cases.

How to test this PR

  • pull code
  • from /domain-ee/ee-ep-merge-app run pytest
  • from /domain-ee/ee-ep-merge-app run pytest ./integration
  • run this CI action to verify successful integration test

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@dfitchett dfitchett requested a review from a team as a code owner December 21, 2023 18:54
Copy link
Contributor

Test Results

144 tests  ±0   144 ✔️ ±0   47s ⏱️ +2s
  39 suites ±0       0 💤 ±0 
  39 files   ±0       0 ±0 

Results for commit 8094b8a. ± Comparison against base commit 57ccd05.

Copy link
Contributor

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.39%

@dfitchett dfitchett requested review from a team, chengjie8 and Ponnia-M December 21, 2023 19:12
Copy link
Contributor

@Ponnia-M Ponnia-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@agile-josiah agile-josiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dfitchett dfitchett merged commit 7e2ac82 into develop Dec 27, 2023
2 checks passed
@dfitchett dfitchett deleted the dfitchett/ep-merge/error-handling-remove-special-issues branch December 27, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants