Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update helm chart versions (#2314) #2388

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Update helm chart versions (#2314) #2388

merged 1 commit into from
Dec 21, 2023

Conversation

Ponnia-M
Copy link
Contributor

  • update domain-xample chart.yaml from 0.2.0 to 0.2.1
  • update svc-bie-kafka chart.yaml from 0.1.3 to 0.1.4

What was the problem?

Incrementing the chart.yaml versions when changes were made.

Associated tickets or Slack threads:

How does this fix it?[^1]

  • chart.yaml versions for domain-xample and svc-bie-kafka will be up to date

How to test this PR

  • Verify on Lens that Version updated

@Ponnia-M
Update helm chart versions (#2314)
6aa6253 
- update domain-xample chart.yaml from 0.2.0 to 0.2.1
- update svc-bie-kafka chart.yaml from 0.1.3 to 0.1.4
@Ponnia-M Ponnia-M requested a review from a team as a code owner December 21, 2023 18:31
@github-actions GitHub Actions
Copy link
Contributor

Test Results

144 tests  ±0   144 ✔️ ±0   47s ⏱️ +2s
  39 suites ±0       0 💤 ±0 
  39 files   ±0       0 ❌ ±0 

Results for commit 6aa6253. ± Comparison against base commit 57ccd05.

@github-actions GitHub Actions
Copy link
Contributor

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.39% ❌

@Ponnia-M Ponnia-M requested a review from dfitchett December 21, 2023 19:15
dfitchett
dfitchett approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@dfitchett dfitchett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ponnia-M Ponnia-M merged commit d641b45 into develop Dec 21, 2023
1 check passed
@Ponnia-M Ponnia-M deleted the charts/ponnia-m branch December 21, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitchett dfitchett dfitchett approved these changes

@chengjie8 chengjie8 chengjie8 approved these changes

@nelsestu nelsestu Awaiting requested review from nelsestu nelsestu is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

@msnwatson msnwatson Awaiting requested review from msnwatson msnwatson is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

@tejans24 tejans24 Awaiting requested review from tejans24

@agile-josiah agile-josiah Awaiting requested review from agile-josiah

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ponnia-M @chengjie8 @dfitchett