Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[svc-bgs-api] Add code comments documenting expected request/response patterns #2352

Merged
merged 7 commits into from
Dec 26, 2023
Merged

[svc-bgs-api] Add code comments documenting expected request/response patterns #2352

merged 7 commits into from
Dec 26, 2023

Conversation

msnwatson
Copy link
Contributor

What was the problem?

Associated tickets or Slack threads:

  • #?

How does this fix it?1

How to test this PR

  • Step 1
  • Step 22

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

  2. To check if a PR will succeed in the SecRel workflow, test PRs in the SecRel pipeline. ↩

@msnwatson msnwatson changed the title Add code comments documenting expected request/response patterns [svc-bgs-api] Add code comments documenting expected request/response patterns Dec 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

Test Results

144 tests  ±0   144 ✔️ ±0   46s ⏱️ -1s
  39 suites ±0       0 💤 ±0 
  39 files   ±0       0 ❌ ±0 

Results for commit e92b204. ± Comparison against base commit 5abe721.

♻️ This comment has been updated with latest results.

@msnwatson msnwatson marked this pull request as ready for review December 13, 2023 18:13
@msnwatson msnwatson requested a review from a team as a code owner December 13, 2023 18:13
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2023 •
edited
Loading

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.25% ❌

chengjie8
chengjie8 approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@chengjie8 chengjie8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

agile-josiah
agile-josiah approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@agile-josiah agile-josiah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msnwatson msnwatson merged commit fae5a0f into develop Dec 26, 2023
1 check passed
@msnwatson msnwatson deleted the mwatson/svc-bgs-api branch December 26, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agile-josiah agile-josiah agile-josiah approved these changes

@chengjie8 chengjie8 chengjie8 approved these changes

@tejans24 tejans24 Awaiting requested review from tejans24 tejans24 is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

@Ponnia-M Ponnia-M Awaiting requested review from Ponnia-M Ponnia-M is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@msnwatson @chengjie8 @agile-josiah