Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Active Spring Profile with BIP config fix #2342

Merged
merged 5 commits into from
Dec 12, 2023
Merged

Conversation

nelsestu
Copy link
Contributor

@nelsestu nelsestu commented Dec 12, 2023

What was the problem?

With Spring Profiles now active in Dev, I stumbled onto the fact that the claimBaseUrl property we consume as a config setting is in fact a hostname. Interpretting the config name claimBaseUrl, I mistakenly set the config value to a URL such as https://claims-dev... This results in a duplicate protocol prefix.

Associated tickets or Slack threads:

How does this fix it?1

This pull request modifies how we consume the claimBaseUrl setting, so that we can safely allow for either specification.

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@nelsestu nelsestu requested a review from a team as a code owner December 12, 2023 06:19
Copy link
Contributor

Test Results

144 tests  ±0   144 ✔️ ±0   46s ⏱️ ±0s
  39 suites ±0       0 💤 ±0 
  39 files   ±0       0 ±0 

Results for commit 069714f. ± Comparison against base commit 5e02efb.

Copy link
Contributor

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.17%

@nelsestu nelsestu changed the title Bip config fix Ensure Active Spring Profile with BIP config fix Dec 12, 2023
@dfitchett
Copy link
Contributor

dfitchett commented Dec 12, 2023

Do you also need app/docker-compose.yml to be updated for the svc-bip-api to include the ENV var? It would need *common-vars to be added to the environment.

...
  svc-bip-api:
    profiles: ["all", "svc", "bip"]
    image: va/abd_vro-svc-bip-api:latest
    environment:
      <<: [ *rabbitmq-placeholder-vars , *common-vars]
...

@nelsestu nelsestu merged commit 1ac6234 into develop Dec 12, 2023
1 check passed
@nelsestu nelsestu deleted the bip-config-fix branch December 12, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants