Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jackson databind to 2.16 #2327

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Conversation

agile-josiah
Copy link
Contributor

User Story

As a VRO engineer, I want to ensure the versions are up to date so that the application isn't vulnerable

Acceptance Criteria

There aren't any remaining jackson-databind dependencies below the latest version

A note about things that should not be considered necessary.

Notes about work

(links to documentation, resources, code, etc that might inform the person doing the work)

@agile-josiah agile-josiah added the dependencies Pull requests that update a dependency file label Dec 11, 2023
@agile-josiah agile-josiah self-assigned this Dec 11, 2023
@agile-josiah agile-josiah requested a review from a team as a code owner December 11, 2023 19:01
Copy link
Contributor

github-actions bot commented Dec 11, 2023

Test Results

38 tests   - 106   37 ✔️  - 107   26s ⏱️ -20s
10 suites  -   29     0 💤 ±    0 
10 files    -   29     1 +    1 

For more details on these failures, see this check.

Results for commit 34d63d3. ± Comparison against base commit e97d91d.

This pull request removes 106 tests.
gov.va.vro.abddataaccess.AppPropertiesTests ‑ testRabbitMqProperties()
gov.va.vro.abddataaccess.exception.AbdExceptionTest ‑ test()
gov.va.vro.abddataaccess.model.AbdResponseTest ‑ test()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testGetAbdEvidence()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testGetBloodPressure()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testGetMedicalEvidence()
gov.va.vro.abddataaccess.service.FhirClientTest ‑ testMedicalEvidenceEmptyBundles()
gov.va.vro.abddataaccess.service.FieldExtractorTest ‑ testBloodPressureMeasurement()
gov.va.vro.abddataaccess.service.FieldExtractorTest ‑ testExtractBloodPressure()
gov.va.vro.abddataaccess.service.FieldExtractorTest ‑ testExtractCondition()
…

♻️ This comment has been updated with latest results.

agile-josiah and others added 7 commits December 11, 2023 12:52
* update workflow

* remove outdated references to 3rd party image tags
* Use latest version of hoppy in merge app
* Adds config for the dev environment.

* Adds a newline to the end of the file

* Adds config for the dev environment.

* Adds a newline to the end of the file

* Fixing spotless java check failure, uncertain where it was introduced but I've the desire to clear the build issues it is causing

---------

Co-authored-by: Erik Nelsestuen <[email protected]>
update assignee and labels for ticket creation from this template
@agile-josiah agile-josiah requested a review from a team as a code owner December 11, 2023 21:57
@agile-josiah agile-josiah merged commit c357b40 into develop Dec 12, 2023
@agile-josiah agile-josiah deleted the josiah/bump-jackson-databind branch December 12, 2023 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants