Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svc-bgs-api enabled to send requests to mock-bgs-api #2288

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

dfitchett
Copy link
Contributor

What was the problem?

svc-bgs-api could not send requests to mock-bgs-api. Also, new bitnami image requires new variable to allow management console connection.

Associated tickets or Slack threads:

How does this fix it?[^1]

These changes allow svc-bgs-api to send requests to mock-bgs-api and receive the mocked response

How to test this PR

  1. Build images and run docker containers
source scripts/setenv.sh
export COMPOSE_PROFILES="bgs"
./gradlew docker
./gradlew -p mocks docker
./gradlew :dockerComposeUp
./gradlew :app:dockerComposeUp
./gradlew -p mocks :dockerComposeUp
  1. Verify RabbitMQ, svc-bgs-api, and mock-bgs-api are running and ready to receive traffic. Note mock-bgs-api can take about minute.
  2. Create a new queue on the bgs-api exchange called response. Be sure to bind the queue to the exchange.
  3. Open to the rabbitmq console to the add-note publish a message with the body {"vbmsClaimId":111,"claimNotes":["hey"]} and add a message property called reply_to with the value response.
  4. Open the response queue page and perform the get message action
    verify it is a 200 and the response is {"status":200}

@dfitchett dfitchett requested a review from a team as a code owner December 1, 2023 19:16
@@ -344,7 +385,7 @@
<name>DevelopmentNotesServicePort</name>
<operations/>
<projectId>x5KVzK</projectId>
<uri>DevelopmentNotesService</uri>
<uri>DevelopmentNotesService/DevelopmentNotesService</uri>
Copy link
Contributor Author

@dfitchett dfitchett Dec 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only non-formatting change in this file, and is required due to the downstream BGS requirement.

Copy link
Contributor

@chengjie8 chengjie8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengjie8 chengjie8 merged commit b361600 into develop Dec 1, 2023
1 check passed
@chengjie8 chengjie8 deleted the dfitchett/bgs-2191 branch December 1, 2023 19:19
Copy link
Contributor

github-actions bot commented Dec 1, 2023

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.26%

@dfitchett dfitchett changed the title Dfitchett/bgs 2191 svc-bgs-api enabled to send requests to mock-bgs-api Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants