Updated to correctly serialize datetimes & refactor lifecycle status endpoint

[dfitchett]

Contained in this PR:

1. Changes code to correctly serialize/deserialize fields expressed as a datetime, i.e., 2023-09-27T00:00:00-06:00
2. This change forced refactor of putClaimLifecycleStatus status due to using the same Beans configured for the restTemplate/rabbitTemplate for message conversion.

• Implements the putClaimLifecycleStatus endpoint as more of a passthrough implementation of the response received from the BIP API similar to the updates implemented in PR Changes BIP API to implement passthrough behavior. #2165 for the getClaimContentions endpoint.

4. Removal of endpoint to set the claim status to RFD, since the putClaimLifecycleStatus endpoint can handle that request

What was the problem?

Date times are not being de/serialized into a date time expressed as a string, but instead as a number of seconds.

Associated tickets or Slack threads:

• Integrate EP Merge app with BIP microservice #2091
• Stacked on PR:
  • Updated cancelClaim endpoint #2237

How does this fix it?¹

Updates the jackson2JsonMessageConverter with an objectMapper configured to use the JavaTimeModule which supports serialization/deserialization of datetime strings into java Instants.

How to test this PR

• Run the unit tests via ./gradlew :svc-bip-api:check
• Start the platform base docker containers to start RabbitMq and start the BIP Mock container (see Docker Compose)
  • run the integration tests via ./gradlew :svc-bip-api:integrationTest
  • build and compose the svc-bip-api docker and run a test by:
    • create a new queue on the bip-api exchange called response
    • open to the rabbitmq console to the putClaimLifecycleStatus
    • publish a message with the body {"claimId":1010,"claimLifecycleStatus":"test"} and add a message property called reply_to with the value response
    • open the response queue page and perform the get message action
    • verify it is a 200 and the response is the mocked response
    • verify time fields
      • open to the rabbitmq console to the getClaimDetailsQueue
      • publish a message with the body {"claimId":1001} and add a message property called reply_to with the value response
      • open the response queue page and perform the get message action
      • verify it is a 200 and the response is the mocked response
      • verify time fields are timestamp formats

Footnotes

1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩

[greene858]

LGTM

[github-actions]

Test Results

143 tests  +3   143 ✔️ +3   46s ⏱️ -1s
  38 suites ±0       0 💤 ±0 
  38 files   ±0       0 ❌ ±0 

Results for commit e27c3ec. ± Comparison against base commit 57e5553.

This pull request removes 2 and adds 5 tests. Note that renamed tests count towards both.

gov.va.vro.bip.service.BipApiServiceTest ‑ testSetClaimToRfdStatus()
gov.va.vro.bip.service.BipApiServiceTest ‑ testSetClaimToRfdStatus_500()

gov.va.vro.bip.service.BipApiServiceTest ‑ testCancelClaimInternalServerError_500()
gov.va.vro.bip.service.BipApiServiceTest ‑ testPutLifecycleStatusInternalServerError_500()
gov.va.vro.bip.service.BipApiServiceTest ‑ testPutLifecycleStatus_200()
gov.va.vro.bip.service.BipApiServiceTest ‑ testPutLifecycleStatus_DOWNSTREAM_ERROR
gov.va.vro.bip.service.BipApiServiceTest ‑ testPutLifecycleStatus_NOT_FOUND

[github-actions]

JaCoCo Test Coverage

File	Coverage [89.8%]	🍏
BipApiService.java	99.79%	🍏
BipRequestErrorHandler.java	81.4%	🍏
RabbitMqController.java	0%	❌

Total Project Coverage	76.26%	❌