Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename vro-request.md to vro-request.yml #2238

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

dianagriffin
Copy link
Contributor

Trying to turn this into a form per GH instructions here: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#creating-issue-forms

What was the problem?

The .md request form template I created turned out kinda messy to use because it opens directly in edit mode, meaning instead of my nicely formatted markdown, users would see a wall of plain text with markdown syntax. I'm trying to use the yaml form option to make the content more readable.

Associated tickets or Slack threads:

How does this fix it?1

I'm hoping this displays the content with embedded form fields, but I don't know how to preview it, so... 🤷‍♀️

How to test this PR

  • I don't know! Is there a way to get a display preview of a .yml file?

Footnotes

  1. Pull-Requests guidelines. If PR is significant, update Current Software State wiki page.

@dianagriffin dianagriffin requested a review from a team as a code owner November 17, 2023 23:06
Copy link
Contributor

Test Results

132 tests  ±0   132 ✔️ ±0   45s ⏱️ -1s
  38 suites ±0       0 💤 ±0 
  38 files   ±0       0 ±0 

Results for commit e420ff8. ± Comparison against base commit 5726134.

Copy link
Contributor

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 76.89%

Copy link
Contributor

@nelsestu nelsestu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no way to really test the form prior to merge, so we'll merge it and see whether you like this version or the textarea/free form markdown better.

@nelsestu nelsestu requested review from a team, tejans24 and greene858 November 18, 2023 03:28
@dianagriffin dianagriffin merged commit 84b1d90 into develop Nov 29, 2023
1 check passed
@dianagriffin dianagriffin deleted the dianagriffin-request-form-template-update branch November 29, 2023 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants