Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix svc-bip-api service unit and integration test #2211

Merged
merged 62 commits into from
Nov 17, 2023
Merged

fix svc-bip-api service unit and integration test #2211

merged 62 commits into from
Nov 17, 2023

Conversation

chengjie8
Copy link
Contributor

@chengjie8 chengjie8 commented Nov 9, 2023 •
edited
Loading

What was the problem?

svc-bip-api service integration test github check was failing constantly on all PRs

Associated tickets or Slack threads:

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

Test Results

110 tests  +110   110 ✔️ +110   45s ⏱️ +45s
  38 suites +  38       0 💤 ±    0 
  38 files   +  38       0 ❌ ±    0 

Results for commit 1e27a2d. ± Comparison against base commit a308606.

♻️ This comment has been updated with latest results.

@chengjie8 chengjie8 self-assigned this Nov 13, 2023
@nelsestu nelsestu mentioned this pull request Nov 13, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 15, 2023 •
edited
Loading

JaCoCo Test Coverage

There is no coverage information present for the Files changed

Total Project Coverage 75.44% ❌

@chengjie8 chengjie8 marked this pull request as ready for review November 15, 2023 04:22
@chengjie8 chengjie8 requested a review from a team as a code owner November 15, 2023 04:22
Merge squashing resolve-bip-test-issues with develop after many of th…
7764f08 
…e individual changes have been merged in with the cancel claim branch
@nelsestu nelsestu force-pushed the resolve-bip-test-issues branch from fe4f095 to 7764f08 Compare November 15, 2023 16:52
dfitchett
dfitchett approved these changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@dfitchett dfitchett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as its passing! 😅

@chengjie8 chengjie8 merged commit 3cb4ba5 into develop Nov 17, 2023
1 check passed
@chengjie8 chengjie8 deleted the resolve-bip-test-issues branch November 17, 2023 16:30
@nelsestu nelsestu mentioned this pull request Nov 20, 2023
Closed
4 tasks
This was referenced Dec 5, 2023
Closed
Closed
@nelsestu nelsestu mentioned this pull request Dec 19, 2023
Closed
8 tasks
This was referenced Jan 18, 2024
Closed
Closed
@nelsestu nelsestu mentioned this pull request Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfitchett dfitchett dfitchett approved these changes

@tejans24 tejans24 tejans24 approved these changes

@greene858 greene858 Awaiting requested review from greene858 greene858 is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

@msnwatson msnwatson Awaiting requested review from msnwatson msnwatson is a code owner automatically assigned from department-of-veterans-affairs/benefits-vro-engineers

Assignees

@chengjie8 chengjie8

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chengjie8 @tejans24 @dfitchett