Add additional Contention Classification database table columns #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing values from kafka generic record
msnwatson
reviewed
Nov 29, 2023
| contentionEventEntity.setDateCompleted(convertTime(bieMessagePayload.getDateCompleted())); | ||
| contentionEventEntity.setDateUpdated(convertTime(bieMessagePayload.getDateUpdated())); | ||
| contentionEventEntity.setActorStation(bieMessagePayload.getActorStation()); | ||
| contentionEventEntity.setAutomationIndicator(bieMessagePayload.getAutomationIndicator()); |
There was a problem hiding this comment.
Can we not chain these set statements? that is
contentionEventEntity.setOccurredAt(...) .setDateAdded(...) . . .
msnwatson
approved these changes
Nov 29, 2023
…ffairs/abd-vro into chengjie8/issue-2085
…ffairs/abd-vro into chengjie8/issue-2085
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem?
We need to store additional data that were not being captured before.
Associated tickets or Slack threads:
How does this fix it?1
BieMessagePayloadobject using java reflectionHow to test this PR
svc-bie-kafkaserviceFootnotes
Pull-Requests guidelines. If PR is significant, update Current Software State wiki page. ↩