WIP MCP-1496 flyway scripts #165
Conversation
There was a problem hiding this comment.
@ianwolson I have added some preliminary comments.
The main ideas is that these tables should match the entity definitions under gov.va.vro.persistence.model,
Tomorrow, let's create an integration test to make sure that this happens.
Also, we need to delete this PR so you can start one. Since I started it, I cannot properly review it. Sorry about that
| PRIMARY KEY(veteran_uuid), | ||
| icn VARCHAR(128) NOT NULL UNIQUE, | ||
| participant_id VARCHAR NOT NULL, | ||
| edipi VARCHAR NOT NULL, |
There was a problem hiding this comment.
what is edipi?
| @@ -0,0 +1,73 @@ | |||
| CREATE TABLE IF NOT EXISTS veteran ( | |||
| veteran_uuid VARCHAR(128) NOT NULL, | |||
| PRIMARY KEY(veteran_uuid), | |||
There was a problem hiding this comment.
I prefer to have all key declarations at the end
| participant_id VARCHAR NOT NULL, | ||
| edipi VARCHAR NOT NULL, | ||
| createdAt timestamp NOT NULL, | ||
| updatedAt timestamp |
There was a problem hiding this comment.
This can also be NOT NULL
| veteran_uuid VARCHAR(128) NOT NULL, | ||
| PRIMARY KEY(veteran_uuid), | ||
| icn VARCHAR(128) NOT NULL UNIQUE, | ||
| participant_id VARCHAR NOT NULL, |
There was a problem hiding this comment.
why do some varchars have length and others not?
| REFERENCES veteran(veteran_uuid), | ||
| id VARCHAR(128) NOT NULL UNIQUE, | ||
| id_type VARCHAR NOT NULL UNIQUE, | ||
| incoming_status TIMESTAMP, |
There was a problem hiding this comment.
That's a varchar
|
|
||
| CREATE TABLE IF NOT EXISTS assessment_result ( | ||
| assessmentResult_uuid VARCHAR(128) NOT NULL, | ||
| claim_uuid VARCHAR(128) NOT NULL, |
There was a problem hiding this comment.
I removed this. We just need contention_id. These table should match up with the entities in the persistence model.
| CREATE TABLE IF NOT EXISTS evidence_summary_document ( | ||
| esd_uuid VARCHAR(128) NOT NULL, | ||
| contention_uuid VARCHAR NOT NULL, | ||
| claim_uuid VARCHAR(128) NOT NULL, |
There was a problem hiding this comment.
This claim_uuid is also gone
| CREATE TABLE IF NOT EXISTS claim ( | ||
| claim_uuid VARCHAR(128) NOT NULL, | ||
| PRIMARY KEY(claim_uuid), | ||
| veteran_uuid VARCHAR(128) NOT NULL, |
There was a problem hiding this comment.
convention should be veteran_id instead of veteran_uuid
| CONSTRAINT fk_contention_uuid | ||
| FOREIGN KEY (contention_uuid) | ||
| REFERENCES contention(contention_uuid), | ||
| evidence_count VARCHAR(128) NOT NULL, |
There was a problem hiding this comment.
this is an integer type
| CONSTRAINT fk_contention_uuid | ||
| FOREIGN KEY (contention_uuid) | ||
| REFERENCES contention(contention_uuid), | ||
| evidence_count VARCHAR(128) NOT NULL, |
There was a problem hiding this comment.
this is an integer type
Feature Name
Description
What was the problem?
How does this fix it?
Jira Tickets
How to test this PR
Reminders
Roadmap wiki pages