Add deploy configurations for API Gateway #1578
Conversation
yoomlam
force-pushed
the
yoom/deploy-apigateway
branch
from
fb213e3 to
3aba7fc
Compare
JaCoCo Test Coverage
|
yoomlam
force-pushed
the
yoom/deploy-apigateway
branch
from
af6ee6d to
d5e0154
Compare
| # Set the context-path. WebFlux calls it base-path | ||
| # https://stackoverflow.com/questions/49196368/context-path-with-webflux | ||
| # Kubernetes rewrites the url to use `/` | ||
| spring.webflux.base-path: / |
There was a problem hiding this comment.
This is the default value, but I want to make this setting explicit since Spring WebFlux uses a different configuration setting than Spring MVC.
| - "8080:8080" | ||
| - "8081:8081" | ||
| - "8110:8110" | ||
| - "8111:8111" |
There was a problem hiding this comment.
Use new ports for our new app (which doesn't have RRD).
| environment: | ||
| <<: *common-vars | ||
| VRO_APP_HOSTNAME: app | ||
| # VRO_CC_HOSTNAME: cc-app |
There was a problem hiding this comment.
Placeholder for Classification Contention's docker container.
| @@ -1,7 +1,7 @@ | |||
| #!/bin/sh | |||
| # prepare the full URL based on the hostname from AWS | |||
|
|
|||
| exec java -jar \ | |||
| eval exec java -jar \ | |||
There was a problem hiding this comment.
Use eval to expand $JAVA_OPTS for compatibility with bash
| @@ -12,7 +12,7 @@ if [ -e /app/entrypoint.sh ]; then | |||
| exec /app/entrypoint.sh "$@" | |||
| elif [ -e "fat.jar" ]; then | |||
| echo "Running ${JAR_FILENAME}; health check port: ${HEALTHCHECK_PORT}" | |||
| exec java -jar fat.jar "$@" | |||
| eval exec java -jar $JAVA_OPTS fat.jar "$@" | |||
There was a problem hiding this comment.
Use eval to expand $JAVA_OPTS for compatibility with bash
| @@ -25,7 +25,7 @@ which python3 | |||
| Install dependencies and run webserver | |||
| ``` | |||
| pip3 install -r requirements.txt | |||
| uvicorn api:app --port 18000 --reload | |||
| uvicorn api:app --port 8120 --reload | |||
There was a problem hiding this comment.
Update so that it follows conventions documented at https://github.com/department-of-veterans-affairs/abd-vro/wiki/Software-Conventions#ports-for-apis-within-vro
| annotations: | ||
| app.kubernetes.io/owner: {{ .Values.owner }} | ||
| app.kubernetes.io/name: {{ .Values.name }} | ||
| app.kubernetes.io/version: {{ .Values.global.version | quote }} | ||
| app.kubernetes.io/env: {{ .Values.global.environment }} |
There was a problem hiding this comment.
Moved to api-gateway's deployment.yaml
| value: /{{ .Values.global.serviceUriPrefix }} | ||
| value: {{ .Values.serviceUriPrefix }} |
There was a problem hiding this comment.
Replaced .Values.global.serviceUriPrefix with chart-specific .Values.serviceUriPrefix
Follow up to #1572
What was the problem?
API Gateway is not deployable to LHDI
Associated tickets or Slack threads:
How does this fix it?
Add deploy configurations for API Gateway
Updated port numbers at https://github.com/department-of-veterans-affairs/abd-vro/wiki/Software-Conventions#port-numbers
How to test this PR