Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: publish to JSR #31

Merged
merged 3 commits into from
Mar 5, 2024
Merged

feat: publish to JSR #31

merged 3 commits into from
Mar 5, 2024

Conversation

eliassjogreen
Copy link
Member

No description provided.

@MierenManz
Copy link
Collaborator

I see a lot of added explicit types, is that a requirement for jsr?

@MierenManz
Copy link
Collaborator

Also wouldn't this mean that our tests in theory also need to be done on bun (and maybe node) ?

MierenManz
MierenManz approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@MierenManz MierenManz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@MierenManz MierenManz merged commit 9d9728d into main Mar 5, 2024
4 checks passed
@eliassjogreen
Copy link
Member Author

I see a lot of added explicit types, is that a requirement for jsr?

Yep indeed. Both your comments are true :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MierenManz MierenManz MierenManz approved these changes

@load1n9 load1n9 Awaiting requested review from load1n9

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliassjogreen @MierenManz