refactor: major refactor of byte_type #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Elias Sjögreen <[email protected]>
Co-authored-by: Elias Sjögreen <[email protected]>
Co-authored-by: Elias Sjögreen <[email protected]>
Co-authored-by: Elias Sjögreen <[email protected]>
…nmanz/byte_type into breaking_change_references
…eaking_change_references
eliassjogreen
requested changes
Nov 13, 2023
|
The last few commits also added type checking on the tagged union discriminant. If you have string keys you need to specify a codec. If it's integers you may specify what type of integer (bigint / 64 bit ints are not supported). Also floats can break the typecheck but I wouldn't know how to fix that. (also doesn't make sense to use floats as discriminant) |
eliassjogreen
approved these changes
Jan 5, 2024
eliassjogreen
changed the title
We can discuss those on discord soon ish maybe? I have some more changes that I want to make to taggedunion for example |
This was referenced Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mega changes have been made.
threetwo types Sized or Unsized. They inherit eachother, so Sized types are also Unsized. Meaning that they will help with type strictness.readPacked,writePacked,readandwrite3. Compound types like structs, arrays, tuples and unions can also be written or read as(not relevant anymore)packedmeaning it reads the least amount of bytes necessaryTaggedUnionIt implements both Aligned and Packed meaning it can be read and written in all the ways possible(not relevant anymore)TODO's for later pr's:
Range checksDoneTestsViewabletypes.Sizedcompound types forViewablestructs etc (lazy reading / writing)