Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: pointers #17

Merged
merged 4 commits into from
May 5, 2023
Merged

feat: pointers #17

merged 4 commits into from
May 5, 2023

Conversation

JinWeiTan
Copy link
Contributor

@JinWeiTan JinWeiTan commented May 4, 2023 •
edited
Loading

Creates a new pointer type.

const MyStruct = new AlignedStruct({
  foo: u32,
});

new AlignedStruct({
  bar: pointer(MyStruct),
});

MierenManz
MierenManz reviewed May 4, 2023
View reviewed changes
types/pointer/pointer.ts Outdated Show resolved Hide resolved
MierenManz
MierenManz reviewed May 4, 2023
View reviewed changes
types/pointer/pointer.ts Outdated Show resolved Hide resolved
@load1n9 load1n9 self-requested a review May 5, 2023 16:34
load1n9
load1n9 previously approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliassjogreen
Copy link
Member

I'm gonna do some surgery and then let someone review one last time 👨‍⚕️

MierenManz
MierenManz previously approved these changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@MierenManz MierenManz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@eliassjogreen eliassjogreen dismissed stale reviews from MierenManz and load1n9 via 8ec3bf4 May 5, 2023 18:39
@eliassjogreen eliassjogreen changed the title feat: pointer feat: pointers May 5, 2023
load1n9
load1n9 approved these changes May 5, 2023
View reviewed changes
Copy link
Member

@load1n9 load1n9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliassjogreen eliassjogreen merged commit bca52d5 into denosaurs:main May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@load1n9 load1n9 load1n9 approved these changes

@eliassjogreen eliassjogreen Awaiting requested review from eliassjogreen

@MierenManz MierenManz Awaiting requested review from MierenManz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JinWeiTan @eliassjogreen @load1n9 @MierenManz