Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add I32LEB128 #11

Merged
merged 16 commits into from
Apr 21, 2023
Merged

feat: add I32LEB128 #11

merged 16 commits into from
Apr 21, 2023

Conversation

MierenManz
Copy link
Collaborator

@MierenManz MierenManz commented Apr 12, 2023

Closes half of #5

@eliassjogreen eliassjogreen self-requested a review April 12, 2023 21:36
@eliassjogreen eliassjogreen changed the title Add Varint feat: add Varint Apr 12, 2023
@eliassjogreen eliassjogreen changed the title feat: add Varint feat: add LEB128 varint Apr 12, 2023
Copy link
Member

@eliassjogreen eliassjogreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good, just a few more tests and some renaming and then its perfect 🌟

types/varint/mod.ts Outdated Show resolved Hide resolved
types/varint/mod.ts Outdated Show resolved Hide resolved
types/varint/mod.ts Outdated Show resolved Hide resolved
types/varint/mod_test.ts Outdated Show resolved Hide resolved
@eliassjogreen eliassjogreen changed the title feat: add LEB128 varint feat: add I32LEB128 Apr 12, 2023
@MierenManz
Copy link
Collaborator Author

Sounds good. Gonna add the suggestions later today

@MierenManz
Copy link
Collaborator Author

@eliassjogreen PTAL

eliassjogreen
eliassjogreen previously approved these changes Apr 21, 2023
types/varint/leb128.ts Outdated Show resolved Hide resolved
@eliassjogreen eliassjogreen merged commit dc59df0 into denosaurs:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants