fix: Strings not properly using offset (#10)

denosaurs · Mar 15, 2023 · 90cc9a8 · 90cc9a8
1 parent 79b28d6
commit 90cc9a8
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/types/array/array.ts b/types/array/array.ts
@@ -57,6 +57,6 @@ export class ArrayType<T> implements SizedType<T[]>, ViewableType<T[]> {
       });
     }
 
-    return array as T[];
+    return array;
   }
 }
diff --git a/types/string/fixed_length.ts b/types/string/fixed_length.ts
@@ -12,14 +12,22 @@ export class FixedLengthString implements SizedType<string> {
 
   read(dataView: DataView, byteOffset = 0): string {
     return decoder.decode(
-      new Uint8Array(dataView.buffer, byteOffset, byteOffset + this.byteLength),
+      new Uint8Array(
+        dataView.buffer,
+        dataView.byteOffset + byteOffset,
+        this.byteLength - byteOffset,
+      ),
     );
   }
 
   write(value: string, dataView: DataView, byteOffset = 0) {
     encoder.encodeInto(
       value,
-      new Uint8Array(dataView.buffer, byteOffset, this.byteLength),
+      new Uint8Array(
+        dataView.buffer,
+        dataView.byteOffset + byteOffset,
+        this.byteLength - byteOffset,
+      ),
     );
   }
 }
-Original file line number
+Diff line change
@@ Expand Up @@
           });
         }
-        return array as T[];
+        return array;
       }
     }