Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: initial version #1

Merged
merged 4 commits into from
Feb 1, 2024
Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Feb 1, 2024

Most of this was back and forth with ChatGPT... seems to be working.

index: 2,
export_type: ExportType::Global,
}
],
Copy link
Member Author

@dsherret dsherret Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left the output of this as low level for now, but we should probably make this higher level in the future and throw away stuff we don't need. Additionally, we should probably parse out functions definitions so that we can create typescript types from it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating TS types would be dope

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, fantastic

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests 👍

@dsherret dsherret merged commit 20bf4a2 into denoland:main Feb 1, 2024
@dsherret dsherret deleted the initial_release branch February 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants