Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite with LSP #5

Merged
merged 2 commits into from
May 9, 2020
Merged

rewrite with LSP #5

merged 2 commits into from
May 9, 2020

Conversation

justjavac
Copy link
Contributor

  • remove 'src'
  • add 'server' and 'client'
  • rewrite with lsp
  • remove snippets

The new version is already available in vscode marketplace: https://marketplace.visualstudio.com/items?itemName=justjavac.vscode-deno

ry
ry approved these changes May 9, 2020
View reviewed changes
Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubberstamp LGTM

@ry ry merged commit f5d6c12 into denoland:master May 9, 2020
@ry
Copy link
Member

ry commented May 9, 2020

(Oops I rebased, I should have squashed. I will in the future.)

@justjavac justjavac deleted the lsp branch May 10, 2020 13:41
@justjavac justjavac mentioned this pull request May 10, 2020
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ry ry ry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justjavac @ry