Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command 'Deno: Reload Import Registries Cache' resulted in an error #394

Closed
jsejcksn opened this issue Apr 16, 2021 · 12 comments · Fixed by #407
Closed

Command 'Deno: Reload Import Registries Cache' resulted in an error #394

jsejcksn opened this issue Apr 16, 2021 · 12 comments · Fixed by #407
Assignees
Labels
bug Something isn't working

Comments

@jsejcksn
Copy link
Contributor

test

Describe the bug
The command palette entry does not seem to work. It only results in the error described below. I'm exploring this feature for the first time.

To Reproduce

  1. Command palette > activate the command named Deno: Reload Import Registries Cache

  2. A notification appears:

Command 'Deno: Reload Import Registries Cache' resulted in an error (Running the contributed command: 'deno.reloadImportRegistries' failed.)

Expected behavior

Not sure. It's never succeeded.

Screenshots

Screen Shot 2021-04-16 at 00 42 16

Versions

vscode: code --version

1.55.2
3c4e3df9e89829dce27b7b5c24508306b151f30d
x64

deno: deno --version

deno 1.9.0 (release, x86_64-apple-darwin)
v8 9.1.269.5
typescript 4.2.2

extension: code --list-extensions --show-versions | grep deno

notes

My .vscode/settings.json looks like this:

{
  "deno.enable": true,
  "deno.lint": true,
  "deno.unstable": false,
  "deno.suggest.imports.hosts": {
    "https://deno.land/": true
  }
}
@kitsonk
Copy link
Contributor

kitsonk commented Apr 16, 2021

There should have been additional information on the OUTPUT tab with the Deno Language Server selected in the dropdown.

@jsejcksn
Copy link
Contributor Author

jsejcksn commented Apr 16, 2021

There should have been additional information on the OUTPUT tab with the Deno Language Server selected in the dropdown.

@kitsonk There wasn't. Below is a screen recording of a reproduction. Is there another way to get diagnostics?

trim

@danopia
Copy link

danopia commented Apr 27, 2021

I'm seeing the same behavior on the same extension version, 3.3.0. I also can't find any output from the action attempt.

@lucacasonato lucacasonato added bug Something isn't working and removed needs investigation labels Apr 27, 2021
@lucacasonato
Copy link
Member

lucacasonato commented Apr 27, 2021

I can also reproduce. Also no error in the log.

image

Also deno.reloadImportRegistries seems to not be in the startup trigger commands, resulting in the command failing with "not found" if it is run before a ts file is opened.

@kitsonk kitsonk self-assigned this Apr 27, 2021
kitsonk added a commit to kitsonk/vscode_deno that referenced this issue Apr 30, 2021
@jsejcksn
Copy link
Contributor Author

Hi @kitsonk: I noticed that you closed this issue, but I am not seeing any change in behavior, other than that now the error is displayed in a modal instead of a notification. Will you please reopen it?

Screen Shot 2021-06-13 at 12 12 21

Updated env info:

% deno --version
deno 1.11.0 (release, x86_64-apple-darwin)
v8 9.1.269.35
typescript 4.3.2

% code --version
1.57.0
b4c1bd0a9b03c749ea011b06c6d2676c8091a70c
x64

% code --list-extensions --show-versions | grep deno
[email protected]

@dsherret
Copy link
Member

I was able to reproduce this. Opened denoland/deno#11123 that should fix it.

@kitsonk
Copy link
Contributor

kitsonk commented Jun 29, 2021

Fixed in denoland/deno#11123

@kitsonk kitsonk closed this as completed Jun 29, 2021
@jsejcksn
Copy link
Contributor Author

jsejcksn commented Jul 1, 2021

@kitsonk Should this be working now? The fix PR was advertised in the release notes for 1.11.3, but I'm still not seeing any change in behavior.

env info:

% deno --version
deno 1.11.4 (release, x86_64-apple-darwin)
v8 9.1.269.35
typescript 4.3.2

% code --version
1.57.1
507ce72a4466fbb27b715c3722558bb15afa9f48
x64

% code --list-extensions --show-versions | grep deno
[email protected]

@dsherret
Copy link
Member

dsherret commented Jul 1, 2021

Just looked into this and another bug related to this was that capturing of client in the creation of the import registries command, which was fixed here:

6bf0454#diff-1cd105d0893b8fff673276402088a4c08a09648ca92c8516f88670f786dc15c8R91-R95

We'll need to do a plugin release too.

@jsejcksn
Copy link
Contributor Author

jsejcksn commented Jul 1, 2021

@dsherret Thanks. Will you please reopen until the fixes are merged?

@kitsonk
Copy link
Contributor

kitsonk commented Jul 1, 2021

They are merge, just not released. We close issues when merged.

@jsejcksn
Copy link
Contributor Author

jsejcksn commented Jul 5, 2021

Just tested in release v3.7.0: There is no UI feedback when running the command, and deno.land import URLs seem to autocomplete as expected.

LumaKernel added a commit to LumaKernel/coc-denoland that referenced this issue Aug 7, 2021
* feat: code lens for references (denoland#308)

* feat: disable most of builtin language service when deno enabled (denoland#307)

* 0.0.8

* feat: add applyCodeActionCommand command (denoland#312)

* fix: remove deno/applyCodeActionCommand (denoland#315)

* New high-res logo (denoland#274)

* feat: add implementations code lens configuration option (denoland#319)

* feat: add initialize workspace command (denoland#316)

* feat: support deno cache quick fix (denoland#322)

* chore: add screenshot to README (denoland#323)

* 0.0.9

* 0.0.10

* fix: typo in init command (denoland#327)

* feat: add a welcome screen for extension (denoland#329)

* feat: use preview instead of display for status (denoland#330)

* chore: README improvements (denoland#331)

* Release 3.0.0, canary is now main (denoland#332)

* 3.0.1

* Fix typo (denoland#337)

Grammar + context

* chore: activate extension on command (denoland#336)

* docs: recommend import_map.json instead of import-map.json (denoland#340)

Resolves denoland#338

* chore: move Releases.md to CHANGELOG.md for better marketplace integration (denoland#344)

Closes denoland#342

* feat: add deno.path setting (denoland#350)

* 3.1.0

* feat: read-add debug support (denoland#351)

Co-authored-by: CGQAQ <[email protected]>

* feat: add settings to affect completions (denoland#368)

* fix: manual `deno` command resolution on windows. (denoland#367)

Fixes denoland#361

* 3.2.0

* feat: support for relative path resolution (using workspaces) in deno.path (denoland#381)

Co-authored-by: Kitson Kelly <[email protected]>

* feat: add version notification message (denoland#383)

* feat: add restart language server command (denoland#385)

Resolves denoland#372

* feat: add support for import registry completions (denoland#380)

* 3.3.0

* typo in ImportCompletions.md (denoland#390)

* fix: activate on reloadImportRegistries command (denoland#407)

Fixes: denoland#394

* feat: handle per resource configuration (denoland#411)

Requires Deno with denoland/deno#10488.

Ref: denoland#348 
Resolves: denoland#314
Resolves: denoland#297

* feat: add internalDebug config flag (denoland#406)

Also integrate upstream formatting changes in deno fmt.

Ref: denoland/deno#10368

* 3.4.0

* feat: recognise json(c) & markdown files (denoland#404)

* 3.5.0

* docs: fix broken link in README (denoland#426)

* feat: support registry auto discovery (denoland#427)

* fix: bump semver of extension (denoland#429)

* 3.5.1

* feat: add support for tasks and test code lens (denoland#436)

* 3.6.0

* fix: update packaging and pin vsce version (denoland#440)

Fixes denoland#439

* 3.6.1

* feat: add support for import map in test code lens (denoland#446)

* fix: activate extension on markdown / json / jsonc (denoland#447)

* fix: setting then clearing "deno.path" config should not use empty string for path (denoland#452)

* fix: better handling when language server fails to start (denoland#454)

* 3.7.0

* fix: remove trailing slash in example (denoland#471)

* chore: remove test header from bug report issue template (denoland#479)

* feat: add ability to set cache directory in settings (denoland#477)

Closes denoland#287

* fix: properly handle plugin configuration at startup (denoland#474)

Fixes denoland#473

Co-authored-by: Kitson Kelly <[email protected]>
Co-authored-by: Luca Casonato <[email protected]>
Co-authored-by: Kirill Reunov <[email protected]>
Co-authored-by: Liam Murphy <[email protected]>
Co-authored-by: Ryan Dahl <[email protected]>
Co-authored-by: Jesse Jackson <[email protected]>
Co-authored-by: CGQAQ <[email protected]>
Co-authored-by: David Sherret <[email protected]>
Co-authored-by: Hector Menendez <[email protected]>
Co-authored-by: Heyward Fann <[email protected]>
Co-authored-by: Satya Rohith <[email protected]>
Co-authored-by: yaegassy <[email protected]>
Co-authored-by: Cedric Vangout <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants